Put browse tab on the menu once and for all

OK so as @lostcarpark points out in Slack, there are three scenarios to test for:

1. Core Drupal without Navigation module
2. Enabled (currently Experimental) Navigation module
3. Enabled Admin Toolbar module

We are behaving "correctly" for Drupal without Navigation, and WITH Navigation (cases 1 & 2).

We are a bit different for the "Admin Toolbar" module. In fact, with only Admin Toolbar enabled, there are still no sub-children under the "Extend" menu. The module admin_toolbar_tools is in fact what registers those paths on the menu, by providing its own menu links yaml, which registers some of those core routes: https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/admin_toolba...

So, I think there are two possible approaches here - use a menu alter to add our menu link *only if admin_toolbar_tools is enabled* -OR- punt this upstream to admin_toolbar.

My hunch is that once we're in core, admin_toolbar will probably support adding the menu link to the Browse route in admin_toolbar_extra_tools the same as it does for, say, the current uninstall route.

One possibility to mitigate why this is an issue for us, is to perhaps enable Navigation in our DrupalPod Try It Now - or NOT enable admin_toolbar_extra?

FWIW I don't think it would make the most sense for a Core module to be altering menu links from a contrib. So I created an issue and a patch for admin_toolbar to try to get it fixed there. There's already a deriver that conditionally adds links for various optional modules, so it fits neatly in there.

(see https://www.drupal.org/project/admin_toolbar/issues/3457902 ✨ Forward Compatibility with Project Browser Active )

Thanks, @gslexie! I tend to agree that would be the preferred path forward.

Looks like the update to admin_toolbar_tools has been merged into 3.5, so this issue is probably either fixed or outdated

@Chris, can you please close this issue?

I have noticed it showing properly in admin_toolbar as of late - that's great! I think this is doing what we want now naturally.

Automatically closed - issue fixed for 2 weeks with no activity.