- Issue created by @Grimreaper
- Merge request !388Issue #3381021: Being able to rename physical file → (Merged) created by Grimreaper
- last update
about 1 year ago 276 pass - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 1:36pm 14 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
Here a first working version.
Inspired from https://www.drupal.org/project/file_rename → , https://git.drupalcode.org/project/file_rename/-/blob/1.0.x/src/Form/Fil....
Needs tests.
I have not handled stuff like prepareDirectoy as it currently only allows to rename the file not move it in another directory.
Also error handling should be done.
Attaching patch from MR for easier Composer usage.
- 🇩🇪Germany jurgenhaas Gottmadingen
This is a nice MR, and it is pretty close to what we need for ECA. It just needs to be developed against the 2.0.x branch of ECA, as no new feature will be going into 1.x. Great coding style too!
I wonder if there should probably also be a config field for a token name under which the resulting file name will be made available? On the other hand, that could be grabbed from the file entity after the event, so probably not?
While we're working together on new features like that, I don't think we need the extra overhead of patches for composer usage. You can also patch from the link above, which is https://git.drupalcode.org/project/eca/-/merge_requests/388.diff - yes, I know they shouldn't be used in production environments, but I feel them to be perfectly OK for development purposes.
I'm going to rebase the MR against the correct branch.
- last update
about 1 year ago 297 pass - Assigned to jurgenhaas
- 🇩🇪Germany jurgenhaas Gottmadingen
Looking into this now as part of ✨ Add new submodule ECA FileSystem Active
-
jurgenhaas →
committed dfef7bd6 on 2.0.x authored by
Grimreaper →
Issue #3381021 by jurgenhaas, Grimreaper: Being able to rename physical...
-
jurgenhaas →
committed dfef7bd6 on 2.0.x authored by
Grimreaper →
- Status changed to Fixed
4 months ago 9:45am 3 May 2024 -
jurgenhaas →
committed 9cc5dfc0 on 2.0.x
Issue #3381021 by Grimreaper, jurgenhaas: Being able to rename physical...
-
jurgenhaas →
committed 9cc5dfc0 on 2.0.x
-
jurgenhaas →
committed 94a45b06 on 2.0.x
Issue #3381021 by Grimreaper, jurgenhaas: Being able to rename physical...
-
jurgenhaas →
committed 94a45b06 on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.