- Issue created by @tim.plunkett
- π¬π§United Kingdom justafish London, UK
tim.plunkett β credited justafish β .
- πΊπΈUnited States mglaman WI, USA
tim.plunkett β credited mglaman β .
- πΊπΈUnited States tim.plunkett Philadelphia
@justafish rightly points out that the fact that this EVER works is concerning, this should probably have some checks around it
- πΊπΈUnited States tim.plunkett Philadelphia
Leaving as major since this seems to be failing 50% of the time, but at least @mglaman has a good explanation for why this ever passed.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
wim leers β made their first commit to this issueβs fork.
-
wim leers β
committed faa9a14b on 0.x authored by
tim.plunkett β
Issue #3529209 by tim.plunkett, justafish, mglaman: Fix typo in .gitlab-...
-
wim leers β
committed faa9a14b on 0.x authored by
tim.plunkett β
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
But based on @mglaman's feedback, this is not actually ready for review, because it's not a solution. Merged it and back to .
- πΊπΈUnited States tim.plunkett Philadelphia
Okay so I noticed something else interesting.
I was the MR author on π External AI Chatbot Functionality Active and Utkarsh and I were joking about how when I push to the branch, the tests pass, but when anyone else pushed we'd have "random fails". Except this Playwright one hasn't felt random.When it's someone else pushing to the fork, the pipeline looks like this
https://git.drupalcode.org/issue/experience_builder-3522013/-/jobs/55488...When I push to it, it looks like this:
https://git.drupalcode.org/project/experience_builder/-/jobs/5549674#L57The directory structure is different! And mirrors the URL structure!
So in my test runs, there is a directory called `experience_builder` but for other test runs it's `experience_builder-3522013`
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
This is a known issue on gitlab. We should use CI_PROJECT_DIR. If that doesn't work, try CI_BUILDS_DIR
- Merge request !1151Issue #3529209: Fix checkout directory in GitLab CI β (Merged) created by justafish
- π¬π§United Kingdom justafish London, UK
I've fixed the directory mismatch on fork branches vs merge requests against the main project, and added a check to verify that the local checkout is being used by composer
Here's the job running in the fork's branch as well for verification: https://git.drupalcode.org/issue/experience_builder-3529209/-/pipelines
- πΊπΈUnited States tim.plunkett Philadelphia
I think this is changing the directory in which CSpell is run, it's now picking up
playwright-report/index.html
- πΊπΈUnited States tim.plunkett Philadelphia
This looks great, thanks @justafish!
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Approved β ship this whenever you want β this is easy/cheap to revert in case it disrupts :)
- First commit to issue fork.
-
balintbrews β
committed a1472040 on 0.x authored by
justafish β
Issue #3529209 by justafish, tim.plunkett, wim leers, mglaman,...
-
balintbrews β
committed a1472040 on 0.x authored by
justafish β