- Issue created by @justafish
- Merge request !1376Issue #3538439: Provide scripts for running tests locally and use them in GitLab CI → (Merged) created by justafish
- 🇮🇳India narendraR Jaipur, India
Applying changes of this MR on 📌 Add Playwright tests for XB AI module Active fixed my issue related to
Unable to install modules ai_agents, experience_builder, xb_ai, xb_ai_test due to missing modules ai_agents.
-
tim.plunkett →
committed 563307d3 on 1.x authored by
justafish →
Issue #3538439: Provide scripts for running tests locally and use them...
-
tim.plunkett →
committed 563307d3 on 1.x authored by
justafish →
- 🇺🇸United States tim.plunkett Philadelphia
justafish → credited tim.plunkett → .
- 🇺🇸United States tim.plunkett Philadelphia
I just merged this, it unblocks XB AI and other XB ecosystem work.
I believe @justafish marked it NW for a follow-up, otherwise it can be closed.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Confirmed that this needs a follow-up and should update an existing issue's summary (#3516348) — although I don't know what follow-up @justafish had in mind.
This looks like an epic step forward! 👏
But it's got a bunch of things that I don't quite understand. See my questions on the (already merged) MR. Among that range of questions, 2 stand out:
- It seems like most of those changes are due to the ability to run CI locally in the same exact way as on GitLab CI (great!), but in doing so it causes this project to deviate further from https://www.drupal.org/project/gitlab_templates → , which increases the maintenance burden here 😬, in particular because those decisions are not documented.
- Furthermore, AFAICT all the carefully crafted rules to only run CI jobs when relevant (e.g. don't run PHP-specific CI jobs when only modifying the UI) have been omitted?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Just a few days later, this has caused:
- yesterday: https://www.drupal.org/project/experience_builder/issues/3540470#comment... 📌 Support for latest 6.x version of justinrainbow/json-schema package Active
- today: https://www.drupal.org/project/experience_builder/issues/3530351#comment... 📌 Decouple image (URI) shape matching from specific image file types/extensions Active
😅
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Support for latest 6.x version of justinrainbow/json-schema package Active is ready to land IMHO, and fixes https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... 😊
(I still think it's great that y'all landed this to be clear — pragmatic progress FTW!)
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Support for latest 6.x version of justinrainbow/json-schema package Active landed, which tied up the most important loose ends. #12 still needs addressing though.