- Issue created by @narendraR
- @narendrar opened merge request.
- ๐ฎ๐ณIndia narendraR Jaipur, India
I have added tests and it is ready for review. However it is blocked on ๐ Runnings tests locally is difficult to match with the CI Active
- ๐ฎ๐ณIndia narendraR Jaipur, India
The blocker has been resolved. I have rebased with the latest changes, and this issue is now ready for review.
- ๐ฌ๐งUnited Kingdom yautja_cetanu
Possibly a follow up issue.
- There needs to be tests for nodes and we need more scenarios
- We need some other Agent Tests: https://www.drupal.org/project/ai_agents_test/issues/3537161 โจ Write a suite for Experience Builder and check any issue Active
- ๐ฎ๐ณIndia kunal.sachdev
This provides a good foundation!! We can include additional tests for page builder tasks and other edge cases in a follow-up.
- ๐ฎ๐ณIndia kunal.sachdev
Follow-up issue created ๐ Expand Playwright test coverage for XB AI module Active
- ๐บ๐ธUnited States tim.plunkett Philadelphia
tim.plunkett โ made their first commit to this issueโs fork.
-
tim.plunkett โ
committed 6f4b39c8 on 1.x authored by
narendrar โ
#3539554: Add Playwright tests for XB AI module
-
tim.plunkett โ
committed 6f4b39c8 on 1.x authored by
narendrar โ
- ๐บ๐ธUnited States tim.plunkett Philadelphia
Merged into 1.x! Not backporting because ๐ Runnings tests locally is difficult to match with the CI Active wasn't backported.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
This caused a regression on
1.x
: it is a new flaky test.I've now seen these new tests fail in multiple MRs, always like this:
3) [webkit] โบ tests/src/Playwright/xbAi.spec.ts:127:7 โบ XB AI Features โบ Should verify AI panel API request and response payload Error: expect(received).toBe(expected) // Object.is equality Expected: "1" Received: "2" 153 | expect(requestBody.messages[0].text).toBe(query); 154 | expect(requestBody.entity_type).toBe('xb_page'); > 155 | expect(requestBody.entity_id).toBe('1'); | ^ 156 | expect(requestBody.selected_component).toBe(''); 157 | expect(requestBody.layout).toBe('{}'); 158 | expect(requestBody.active_component_uuid).toBe('');
โ https://git.drupalcode.org/project/experience_builder/-/jobs/6274833#L1337
While it's still fresh in your head, please harden this ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Also, many more failures from this new test coverage in https://git.drupalcode.org/project/experience_builder/-/jobs/6275720 (4 of the 6 failures!) โ although maybe those failures are caused by the changes in that MR, although I really don't see how.
I'll re-test it (queued: https://git.drupalcode.org/project/experience_builder/-/jobs/6275778), but would very much appreciate you manually testing the AI functionality with that MR checked out. ๐
- @narendrar opened merge request.
- First commit to issue fork.
- First commit to issue fork.
-
jessebaker โ
committed 1efd36ab on 1.x authored by
narendrar โ
Issue #3539554 by narendrar, justafish, tim.plunkett: Add Playwright...
-
jessebaker โ
committed 1efd36ab on 1.x authored by
narendrar โ
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Much appreciated, @NarendraR, @justafish and @jessebaker! ๐๐