- Issue created by @wim leers
- Merge request !1190Recipes alone should be enough; this should not be necessary. Otherwise... β (Merged) created by wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I doubt it's causing this, but just in case: also revealed this (edge case-y!) Recipes bug: π \Drupal\Core\Recipe\ConfigConfigurator unsets the uuid of active configuration, but it should only do that if the recipe data does not contain a UUID Active .
- First commit to issue fork.
- π¬π§United Kingdom justafish London, UK
phenaproxima β credited justafish β .
- πΊπΈUnited States phenaproxima Massachusetts
Trying to credit @justafish for help debugging this in a back channel.
- πΊπΈUnited States phenaproxima Massachusetts
This is now in a much better place thanks to @justafish's targeted simplification of the code that applies recipes to the test site.
It's still failing, but for a completely clear reason:
/builds/issue/experience_builder-3532268/_drupal/web/../web/modules/contrib /experience_builder/tests/fixtures/recipes/test_site/content/node/c66664af- 53b9-42f4-a0ca-8ecc9edacb8c.yml: field_xb_demo.1.inputs.348bfa10-af72-49cd- 900b-084d617c87df.image.src=Invalid URL format.
If I go look at that spot, I see this (truncated for brevity):
inputs: '{"image":{"sourceType":"static:field_item:entity_reference","value":{"target_id":"1"} ...
I don't think we can rely on images by serial ID -- only by UUID. That would be my first guess as to why this isn't working.
Is this a known issue? Fixed in some way? Out of scope here? I could use some input from Wim or another elder XB wizard.
- First commit to issue fork.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Traced the validation error down to
\Drupal\Core\StreamWrapper\PublicStream::baseUrl
when we're running that viacore/scripts/drupal
the base URL ends up being borked and the URL is invalid. Made a tweak to the playwright setup that should fix it - πΊπΈUnited States phenaproxima Massachusetts
If
core/scripts/drupal
is setting a bad base URL, that sounds like something that should be fixed in core as well. I'll open a follow-up for that. - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Wow, epic work here, all three of you! π€―π
Just one question:
target_id
should not be present in the default content export? Can its presence not cause problems? Should that be tackled in a follow-up, too? - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
But how can we know it won't cause other side effects?
Besides, AFAICT this currently doesn't actually do what we want it to do? π See https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
(Found 2 bugs AFAICT.)
- πΊπΈUnited States phenaproxima Massachusetts
Having a test makes of ton of sense and catches the bug you found.
- πΊπΈUnited States phenaproxima Massachusetts
Opened follow-up to actually fix this in core: β¨ EntityReferenceItem should support a virtual `target_uuid` property Active
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
RTBC as far as I'm concerned now β can't approve the MR because I created it originally πΆβπ«οΈ
- πΊπΈUnited States phenaproxima Massachusetts
Synced the branch with 0.x, restoring RTBC.
-
wim leers β
committed 2e9d7bee on 0.x
Issue #3532268 by phenaproxima, wim leers, justafish, larowlan: XB's `...
-
wim leers β
committed 2e9d7bee on 0.x