AccountForm clean-up

Created on 5 August 2013, almost 12 years ago
Updated 29 May 2025, 2 days ago

Problem/Motivation

From #1998648-53: "Administration pages language" user account setting should be hidden if not used
Some form elements in AccountForm are created only under certain conditions.
contrib' form_alters have to check for elements existence before modifying them.

This is a problem because

  • the extra form_alters make performance worse?
  • it is bad contributor developer experience (CX)

Postponed on 8.1.x per https://www.drupal.org/contribute/core/beta-changes

Proposed resolution

"standardize" them by using #access

Remaining tasks

User interface changes

No. (The UI should be the same before and after. We should have screenshot to prove that.)

API changes

No.

📌 Task
Status

Needs work

Version

11.0 🔥

Component

user.module

Created by

🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

Live updates comments and jobs are added and updated live.
  • API clean-up

    Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

  • Security

    It is used for security vulnerabilities which do not need a security advisory. For example, security issues in projects which do not have security advisory coverage, or forward-porting a change already disclosed in a security advisory. See Drupal’s security advisory policy for details. Be careful publicly disclosing security vulnerabilities! Use the “Report a security vulnerability” link in the project page’s sidebar. See how to report a security issue for details.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Merge request !12270Adapt patch from comment 49 → (Open) created by prudloff
  • Pipeline finished with Failed
    2 days ago
    Total: 777s
    #509750
  • Pipeline finished with Success
    2 days ago
    Total: 1276s
    #509765
  • 🇫🇷France prudloff Lille

    I rebased the latest patch and tests are passing but I did not test manually.

  • 🇺🇸United States smustgrave

    Think the issue summary needs some love. The motivation section mentions performance? But anything to support that?

    Was also mentioned as a remaining task

    The 8.1 I think is out of date haha

  • 🇫🇷France prudloff Lille

    I tried to rewrite the summary.

Production build 0.71.5 2024