_drupal_log_error() should return a non-zero exit code on errors in the cli

Merge request created.

Thanks for reporting/working on this. The same change seems to be already in D10, see: #2927012: _drupal_log_error() returns a 0 exit code on errors → , so I think this looks good.

Not sure if we can easily backport the test from D10, as we do not have PhpProcess. Any thoughts? Did not have time to look at that more thoroughly yet.

Hey nice find!

We could copy the code from Symfony Process for the test, but not sure if it is worth it to try to port that somehow?

I would say we can commit this without test, since it does not affect end users and is just for command line invocations.

Looks good, I think we can merge this small change.

I don't think we need to jump through hoops to backport the test to D7.

However, per #2927012-33: _drupal_log_error() returns a 0 exit code on errors → it deserves a Change Record as it may cause a change in the behaviour of tests.

I have created a draft CR for D7: https://www.drupal.org/node/3438765 → (it is mostly the copy from the D8 CR).

Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.