- π¨π¦Canada joseph.olstad
@DamienMcKenna, please add PHP 8.1 to the automated tests.
and maybe set PHP 8.0 or 8.1 as the default as 7.4 is EOL since december 2022. - πΊπΈUnited States DamienMcKenna NH, USA
I switched the default test run to PHP 8.0. Once we fix the PHP 8.2 tests I'll update the tests to use it. IMHO adding 8.1 would be a wasted effort.
- Status changed to Closed: duplicate
almost 2 years ago 1:08am 15 February 2023 - πΊπΈUnited States DamienMcKenna NH, USA
This should be fixed in π PHP 8.x deprecated function warning at runtime Fixed
- Assigned to tibezh
- Status changed to Active
11 months ago 10:53am 20 December 2023 - πΊπ¦Ukraine tibezh
I can see that the issue is still present, seems the patch should be fix the issue.
- last update
11 months ago 234 pass - last update
11 months ago 234 pass - last update
11 months ago 234 pass - Issue was unassigned.
- Status changed to Needs review
11 months ago 11:04am 20 December 2023 - last update
11 months ago run-tests.sh exception - last update
11 months ago run-tests.sh exception - last update
11 months ago run-tests.sh exception - last update
11 months ago run-tests.sh exception - Status changed to RTBC
11 months ago 2:32pm 20 December 2023 - π¦πΉAustria klausi π¦πΉ Vienna
OK, interesting that the sorting direction fixes the tests? But if we are green now on all PHP versions this is fine!
- πΊπΈUnited States DamienMcKenna NH, USA
Thanks for fixing the test coverage. Let's add this to the next release.
- π¨π¦Canada joseph.olstad
@tibezh, thanks for this fix, which , for whatever reason I've never understood why and how this is a fix but I've seen PHP 8.2 issues related to this before. I have never understood this issue fully but your very small change does fix the test and amazingly doesn't cause a regression.
- π¨π¦Canada joseph.olstad
@DamienMcKenna, you'll also want to commit this fix, also by @tibezh
π Views plugin query: TypeError: explode(): Argument #2 ($string) must be of type string RTBC -
DamienMcKenna β
committed 553ff357 on 7.x-3.x authored by
tibezh β
Issue #3332486 by tibezh, DamienMcKenna, joseph.olstad, klausi: Fix PHP...
-
DamienMcKenna β
committed 553ff357 on 7.x-3.x authored by
tibezh β
- Status changed to Fixed
11 months ago 11:15am 21 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.