Support parse HTTP headers with multiple lines in drupal_http_request()

Open on Drupal.org →

Created on 27 February 2024, 9 months ago

Problem/Motivation

I have a page that returns HTTP headers in multiple lines in response.
drupal_http_request() does not support parsing (processing) them, we have a PHP warning instead.

According to RFC 2616 the feature was known as "Line Folding":

HTTP/1.1 header field values can be folded onto multiple lines if the continuation line begins with a space or horizontal tab. All linear white space, including folding, has the same semantics as SP. A recipient MAY replace any linear white space with a single SP before interpreting the field value or forwarding the message downstream.

So the following two forms were equivalent:

Header: value1, value2

and

Header: value1,
        value2

Proposed resolution

According to existing functionality, we can add a function to normalize headers.

🐛 Bug report

Status

Version

7.0 ⚰️

Component

Last updated about 4 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇬🇧United Kingdom @catch
🇬🇧United Kingdom @alexpott
🇦🇺Australia @larowlan
🇺🇸United States @bnjmnm
🇫🇷France @nod_
🇪🇸Spain @ckrina
🇬🇧United Kingdom @justafish

Created by

🇺🇦Ukraine tibezh

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!6784Support parse HTTP headers with multiple lines in drupal_http_request()
Open
🇺🇦Ukraine tibezh
updated 9 months ago

Comments & Activities

Issue created by @tibezh
Merge request !6784Issue #3423981 → (Open) created by tibezh
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update 9 months ago
2,168 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update 9 months ago
2,168 pass
Pipeline finished with Canceled
9 months ago
Total: 182s
#104797
Pipeline finished with Canceled
9 months ago
Total: 126s
#104799
Pipeline finished with Success
9 months ago
Total: 247s
#104802
Issue was unassigned.
Status changed to Needs review 9 months ago8:43am 27 February 2024
Comment 9 months ago →
🇺🇦Ukraine tibezh
Changes are available in the https://git.drupalcode.org/project/drupal/-/merge_requests/6784 MR.
Status changed to RTBC 9 months ago9:40am 27 February 2024
Comment 9 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Nice, I think it is ok that we are only testing this with a unit test. In PHP you cannot even produce a header() call with a multi-line header, so this is hard to test with a functional test.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024