#options values usually have to run through t() for translation

Issue created by @arti_parmar
Issue was unassigned.
Status changed to Needs review over 1 year ago7:23am 22 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
19 pass
Comment over 1 year ago →
🇮🇳India arti_parmar
Kindly review patch.
Status changed to RTBC over 1 year ago8:05am 22 June 2023
Comment over 1 year ago →
🇮🇳India AkashKumar07
The #2 changes look good to me. Moving to RTBC.

Thanks!
Status changed to Needs work over 1 year ago9:18am 22 June 2023

🇮🇹Italy apaderno Brescia, 🇮🇹

-    $this->assertSession()->pageTextContains(t('An attempt has been made to send an e-mail to @email.', ['@email' => $account->getEmail()]));
+    $this->assertSession()->pageTextContains($this->t('An attempt has been made to send an e-mail to @email.', ['@email' => $account->getEmail()]));

With the title this issue has, this is an off-topic change.

Also, merely quoting warnings/errors given from a tool is not describing the issue and what it needs to be done.

Status changed to RTBC over 1 year ago9:28am 22 June 2023
Comment over 1 year ago →
🇮🇳India arti_parmar
yes @AkashKumar07,
Thanks for review.
Status changed to Needs work over 1 year ago11:43am 22 June 2023
Comment over 1 year ago →
🇮🇳India AkashKumar07

#options values usually have to run through t() for translation

Comments & Activities