- Issue created by @sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 7:51am 22 June 2023 - 🇮🇳India AkashKumar07
The patch naming convention is not correct. For more details please refer to https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
I reviewed the patch and found some coding standard issues.
Please follow the below suggestion./** @var \Drupal\block\BlockInterface $block */ $block = \Drupal::entityTypeManager() ->getStorage('block') ->load($variables['elements']['#id']); if ($block) {
Thanks!
- Status changed to Needs review
over 1 year ago 8:56am 22 June 2023 - Assigned to sonam_sharma
- Status changed to Needs work
over 1 year ago 9:08am 22 June 2023 - 🇮🇳India AkashKumar07
Reviewing #4.
The block condition closing is not correct. It should be closed afterif ($variables['base_plugin_id'] === 'search_form_block') {}
Reviewing #5
The patch naming convention is not correct. Please refer to this guideline.
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →Thanks!
- Status changed to Needs review
over 1 year ago 9:27am 22 June 2023 - Status changed to Needs work
over 1 year ago 7:07am 28 June 2023 hello @AkashKumar07
I think the patch is working fine can you please describe in detail what's wrong in this patch
so, I will try to resolve this error- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** @var \Drupal\block\BlockInterface $block + * The Block variable. + */ + $block = \Drupal::entityTypeManager()
Such comments are not used inside functions/methods. If you are trying to type-hint that variable, then the comment to add is the following one.
/** @var \Drupal\block\BlockInterface $block */ $block = \Drupal::entityTypeManager() ->getStorage('block') ->load($variables['elements']['#id']);
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
In the case of a bug, the description should also list the steps necessary to reproduce the issue, starting from when the module/theme is installed.