Fix method signature in FeaturesConfigInstaller::findPreExistingConfiguration() for Drupal 11.2+ compatibility

Created on 15 July 2025, 2 months ago

Problem/Motivation

PHP Fatal error: Declaration of Drupal\features\FeaturesConfigInstaller::findPreExistingConfiguration(Drupal\Core\Config\StorageInterface $storage) must be compatible with Drupal\Core\Config\ConfigInstaller::findPreExistingConfiguration(Drupal\Core\Config\StorageInterface $storage, array $previous_config_names = []) in modules/contrib/features/src/FeaturesConfigInstaller.php on line 67

This happens because `ConfigInstaller::findPreExistingConfiguration()` in core was updated in [Drupal 11.2.0]( https://www.drupal.org/project/drupal/releases/11.2.0 → ) to include a new second parameter:
```php
array $previous_config_names = []
The override in Features does not match this updated method signature, causing a fatal error.

When using the Features module with Drupal 11.2.x and higher, the following fatal error occurs when running `drush updb` or similar config-installing operations:

Proposed resolution

Update the method signature in FeaturesConfigInstaller to match Drupal core:

- protected function findPreExistingConfiguration(StorageInterface $storage)
+ protected function findPreExistingConfiguration(StorageInterface $storage, array $previous_config_names = [])

Attached is a simple patch that updates the method signature.

Manually tested on Drupal 11.2.2
Confirmed fix for drush updb
Compatible with existing functionality

🐛 Bug report

Status

Needs review

Version

3.14

Component

Code

Created by

🇺🇸United States jbowm2

Live updates comments and jobs are added and updated live.

Drupal 11 compatibility

fatal error

Comments & Activities

Issue created by @jbowm2
Comment about 2 months ago →
🇧🇪Belgium Jonasanne
I also tested this on 11.2.2 and can confirm it works.
Thanks
Comment about 2 months ago →
🇧🇪Belgium Jonasanne
Converted the patch into a MR.
@jonasanne opened merge request.
Comment about 1 month ago →
🇺🇸United States mark_fullmer Tucson
Noting that this change is already accounted for in the issue for Drupal 11 compatibility, per https://git.drupalcode.org/project/features/-/merge_requests/39#note_494953 . So, presumably, this issue can be closed in favor of the comprehensive changes in 📌 Drupal 11 compatibility for Features module Active
Comment 9 days ago →
🇺🇸United States bkosborne New Jersey, USA
Comment 9 days ago →
System Message
Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024