This is working in Drupal 11.1.4.
Opened a new merge request for version 11.x. It includes several bug fixes, improvements, and test adjustments. I did my best to model all changes based on pre-existing solutions in the node revisions implementation.
I haven’t figured out how to resolve the core/modules/jsonapi/tests/src/Functional/CommentTest.php test. Maybe someone who is familiar with that test can jump in? The other failing tests do not seem related to these changes, but I could be wrong.
There probably needs to be new tests created for comment content moderation and for the user cancel changes. Unfortunately, I won’t have time to work on these immediately. Please feel free to jump in if you'd like.
- Added the missing revision keys to the config and tests.
- Added the revision UI, links, and access control.
- Kept the existing comment permission structure with
administer commentsbeing the permission that can perform revision CRUD operations. - Removed the base field alter hook because this should be configured in the content moderation workflow rather than in the code.
- Added shared table indexes for the
comment_revisiontable. - Created
comment_mass_update, a carbon copy ofnode_mass_update, to primarily handlehook_user_canceloperations gracefully. It includes a new$syncingoption to prevent the creation of new revisions when reassigning comments to the anonymous user account. A similar issue for nodes exists at [ https://www.drupal.org/project/drupal/issues/3062900] → ( https://www.drupal.org/project/drupal/issues/3062900 → ). - Added a comment moderation handler.
- Updated the comment links renderer to be aware of revisions.
robbiehobby → changed the visibility of the branch 11.x to hidden.
Attaching a patch file that applies cleanly to version 2.0.0-alpha3.
A new MR has been opened for version 2.x. Test cases and PHPCS issues have been fixed. There are some additional warnings from cspell and stylelint that are not related to these changes.
robbiehobby → changed the visibility of the branch 8.x-1.x to hidden.
robbiehobby → changed the visibility of the branch 2.0.x to hidden.
robbiehobby → changed the visibility of the branch 2746715-runtime-should-be to hidden.
robbiehobby → changed the visibility of the branch 8.x-3.x to hidden.
I could not confirm this issue. Non-existent entity pages with dynamic path aliases correctly displayed a 404 error. Please reopen the ticket with additional information if the problem persists.
robbiehobby → made their first commit to this issue’s fork.
Closing due to insufficient information to confirm the issue. Please reopen when you have additional details.
I understand how comments could be useful, however, this module relies on the Drupal core conditions API, which manages path parsing. I prefer not to introduce changes that deviate from the core's behavior or add unnecessary code. Thanks for the recommendation though.
As a workaround, you could keep a plain text note or README in the project to describe the configuration.
Drupal 11 support has been released. Thanks for the co-maintainer offer.
Merged. New release will be up shortly. Thanks for the reminder.
robbiehobby → made their first commit to this issue’s fork.
greggles → credited robbiehobby → .
You'll also need to exclude the Ajax autocomplete URL. It usually looks like /ajax/autocomplete. If you're not sure, take a look at your network tab in the developer tools.
Re-rolled for 8.x-1.7
robbiehobby → created an issue.
robbiehobby → created an issue.
robbiehobby → created an issue.
robbiehobby → created an issue.
robbiehobby → created an issue.
robbiehobby → created an issue.
+1 RTBC
robbiehobby → created an issue.
Unfortunately, no because Uppy.js considers uploads as unordered. See https://github.com/transloadit/uppy/issues/1779#issuecomment-522512989. I may build an extension in the future if they don't add some kind of order support soon.
robbiehobby → created an issue.
Thanks. Merged and will be included in the next release.
+1 RTBC
Re-rolled for 10.3.x
Re-rolled for 10.3.x
robbiehobby → changed the visibility of the branch 9.1.x to hidden.
robbiehobby → created an issue.
Could you also provide the Drupal version, module version, and specify any other file related installed modules.
What does your configuration look like? I'll need more information to be able to assist you.
BramDriesen → credited robphillips → .
Took a crack at the problem. Search API Solr offers up a similar solution. Re-index is only triggered when a indexed field has changed. Tested with both in-site configuration changes and using configuration sync. There might be some edge cases. Definitely needs more eyes on it.
https://git.drupalcode.org/project/search_api_solr/-/blob/4.x/src/Plugin...
robphillips → made their first commit to this issue’s fork.
robphillips → created an issue.
At the moment it can only be added to an entity form display. Leaving this open as I might find time to convert to a form element type.
You need to re-install the module and disable the filter on every text format before uninstalling. This is a known issue in Drupal core.
robphillips → created an issue.
robphillips → made their first commit to this issue’s fork.
robphillips → created an issue.
robphillips → made their first commit to this issue’s fork.
The field definition should never be null so this patch is not correct. Take a look at the lines immediately before your changes (shown below). If the comment entity doesn't have a field something in your sites entity or configuration is broken.
$commentedEntity = $comment->getCommentedEntity();
/** @var \Drupal\field\FieldConfigInterface $fieldDefinition */
$fieldDefinition = $commentedEntity->getFieldDefinition($comment->getFieldName());
If you could provide steps to replicate on a fresh installation I will reopen.
robphillips → created an issue.
Adding D10.1 compatible patch based on latest MR.
Thanks to all for contributing. Both specific and unlimited limits have been resolved. With one caveat... unlimited is actually limited to 10,000 because the Choices.js library doesn't have an unlimited option.