Argument default about revision id from url

Created on 12 November 2019, about 5 years ago
Updated 20 February 2024, 10 months ago

Problem/Motivation

Goto View -> Contextual Filter -> Provide default value,

If we need filter by revision id, not have the option about Revision ID from URL, only Content ID from URL.

I think this is basic feature that retrieve revision id from url.

Proposed resolution

- Create new ViewsArgumentDefault for Revision ID from URL

Remaining tasks

-
- Unit test
Review
Add before and after screenshots to the Issue summary.

User interface changes

In View -> Contextual Filter -> Provide default value, we can see Revision ID from URL.

API changes

None.

✨ Feature request
Status

Needs work

Version

11.0 πŸ”₯

Component
Node systemΒ  β†’

Last updated 4 days ago

No maintainer
Created by

πŸ‡¨πŸ‡³China Oscaner

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs screenshots

    The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    @acbramley not as familiar with that but if we put a conditional do you think that will cause issues?

  • πŸ‡¦πŸ‡ΊAustralia acbramley

    @smustgrave a conditional in the validator? Yeah that could work. However, I think we should come at these argument default plugins from a different angle and look at implementing an entity type agnostic plugin that is configurable to be entity id or revision id.

    Right now we have a plugin for Node, and another plugin for Taxonomy (with some really wild config that I'd never seen before!).

    Most of the time people will just want a default argument that takes the entity's ID. We should be able to derive the entity type from the route, and then we don't need N plugins for N entity types. We can also let that plugin handle revisions too.

Production build 0.71.5 2024