jeremy1606 → made their first commit to this issue’s fork.
Hello, I participated in the “Drupal 11 compatibility” task for the “Currency” module, and no one gave me any attributes or credits for my participation. You are a maintainer, and I wanted to ask if you could give me attributes or credits for my company and for myself? Thank you very much in advance.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
Commit fba55534 demonstrates that the test will fail correctly if entity_type is missing.
Commit f20e3b11 demonstrates that the plugin depends on entity_type to function correctly.
Refactored multiple classes to eliminate direct \Drupal service calls, replacing them with proper dependency injection. Updated constructors and .services.yml definitions where needed. This includes forms, event subscribers, mappers, and the role list builder. As a result, all PHPCS violations related to service usage have been resolved. PHPUnit tests were re-run and confirmed to pass after the changes.
This work also works for updating the module to Drupal 11. I welcome any suggestions or comments.
I have updated the Sendgrid module to fix several issues related to deprecated methods, dependency injection, and PHPStan errors. Specifically:
- Fixed the constructor in SettingsForm.php and TestEmailForm.php to properly handle the TypedConfigManagerInterface.
- Replaced the deprecated RendererInterface::renderPlain() with renderInIsolation().
- Updated SendgridMail.php to use Soundasleep\Html2Text correctly, avoiding instantiation errors.
- Ensured compatibility with the latest SendGrid PHP library and resolved missing class issues.
- Minor adjustments to the sendgrid.html.twig template and the cspell wordlist.
- After these changes, PHPUnit tests pass without errors, and PHPStan reports no remaining critical issues.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
I have added a kernel test to validate the fix applied in UrlPath.php, where the original condition was modified to avoid a deprecation warning when calling ctype_digit() with a NULL value. The new conditional first checks that $lastSegment is not empty before applying ctype_digit(), which resolves the reported issue when accessing a view such as /foo without the arg_0 parameter. To ensure that the plugin behaves correctly in all scenarios, I created the file tests/src/Kernel/NullUrlPathArgumentTest.php with two tests: testNullLastSegment, which simulates a path with arg_0 = NULL and confirms that the plugin returns an empty string without errors; and testNumericSegment, which verifies that a numeric argument such as ‘123’ is handled correctly and returned as is. Both tests pass successfully and confirm that the plugin now works safely and robustly. If further work is needed, I welcome comments and suggestions.
jeremy1606 → made their first commit to this issue’s fork.
I’ve added a functional test to cover this scenario. The new test installs migrate_tools without migrate_plus, logs in with a user that has the “administer migrations” permission, and attempts to access /admin/structure/migrate. The test ensures that the route does not trigger a fatal error (accepting 200/403/404 as valid outcomes). This should prevent regressions and confirm that the fix in !97 works as expected.
jeremy1606 → changed the visibility of the branch 3536772-add-migrate-plus-dependency to hidden.
jeremy1606 → changed the visibility of the branch 3513062-core-php-next to active.
jeremy1606 → changed the visibility of the branch 3513062-core-php-next to hidden.
I understand. What would be your recommendations for me and the job in general? I would like to help
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
I have created MR!3 for the module's update to D11. I hope this is helpful. I have tested the module locally and everything seems to be working fine. I am open to comments and/or suggestions.
jeremy1606 → created an issue.
I was just here to help, and I'm glad to know that I can be of use. If you need help with anything else, I'm open to comments and suggestions so that we can get to “Fixed” very soon.
jeremy1606 → made their first commit to this issue’s fork.
I have made two commits and added two files to run the tests and correct cspell errors (.cspell-project-words.txt & .gitlab-ci.yml).
jeremy1606 → made their first commit to this issue’s fork.
This class was modified to extend ContentEntityForm instead of NodeForm in order to avoid using an internal API and comply with Drupal 11 coding standards and PHPStan rules.
Related change: all remaining references to NodeForm in the module (e.g., in EntityOperations) were replaced with ContentEntityForm to ensure compatibility and eliminate dependency on internal core classes.
jeremy1606 → made their first commit to this issue’s fork.
I made a commit in which I fixed two misspelled words in test/
All tests passed, and I am open to comments or suggestions.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
Of course, I have also tested the module and can guarantee that it works, so: +1 RTBC
I added a cspell-project-words.txt file to avoid the only error that cspell flagged in the GitLab pipelines, since, upon searching for the error, it was a word that could not be changed within README.md. The composer.json has also been changed from 2.x to avoid the validation error in the composer-lint test.
jeremy1606 → made their first commit to this issue’s fork.
I have added a commit where I add compatibility with D11 in the submodules of the main module by editing their .info.yml files. I welcome any suggestions or comments.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
Hello. I have added a new commit doing what was requested in comment #6. The pipelines have passed. I await review. Thank you.
I have resolved the warnings generated by the Gitlab tests in “Fixing only issues of phpstan II (#537580)” with commit 2123196f. I tested it on my D11 site and it worked perfectly.
These warnings were:
- cspell
- eslint
- phpcs
- phpstan
- stylelint
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → created an issue.
I wanted to install this module on my D11 site and if I could do it, I also have to install a dependency. When I tested it on my site it worked correctly.
When I wanted to install this module in my D11 project I couldn't because there was no Core support yet. So, I had to:
- Modify the info.yml manually to allow me to install it.
- Once this modification was done I added a commit.
- I made a push with the new changes.
Then I could install it in my project and it worked perfectly. The MR I did was #4.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
That module works and is fine. I have tested it and got no errors. I have followed the steps:
1. Navigate to Administration > Extend and enable the module.
2. Navigate to Administration > Structure > Views.
3. There is now a “Has taxonomy term name with Depth” contextual filter.
If the Taxonomy options appear.
This module works and is fine. I tested it and got no errors.
I have tested this module on my drupal site through a view. I added a numeric ID value and then activated the “Use tokens in value” option.
I tested the module and configured in D11.1, configured a view and look it logs. There were not errors.
The steps:
- A simple view both filters from this module.
- Only the left filter display in the settings I could not remove add or configure the filter.
- Every time when I try to save give me an error.
Error message
Field set in Global: Field contained is not set in this display.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
The problem you are facing is because resource is a reserved word in PHP since version 7.0. In this case, the warning indicates that the word resource is being used within the namespace in several classes within the Drupal migrate_example_advanced module.
The most recommended is to rename the namespace within the affected files. Currently, the namespace is defined as:
Drupal namespace Drupal\migrate_example_advanced\Plugin\resource;
You can change it to something more secure, like resources or rest_resource, for example:
Drupal namespace Drupal\migrate_example_example_advanced\Plugin\rest\rest_resource;
Then, in each file where this namespace is used, make sure to update the corresponding references.
jeremy1606 → made their first commit to this issue’s fork.
Pin an existing version of core-composer-scaffold, this is because the previous update does not work, you can manually pin the latest version of drupal/core-composer-scaffold compatible with 10.3.x
1) composer require drupal/core-composer-scaffold:^10.0 --no-update
2) composer update -W drupal/core-recommended drupal/core-dev drupal/core-composer-scaffold
This patch is giving me a mistake: patch -p1 < filefield_sources_d10compat_3336268.patch
jeremy1606 → made their first commit to this issue’s fork.
jeremy1606 → made their first commit to this issue’s fork.
I will try to test to see if they will pass.
Of course. I've already done it. Can you check it please and tell me if it's ok now?
By accident two empty commits were sent. But I managed to update the two modules with composer and they are already in versions 4.0.0 and 2.0.0 respectively.
jeremy1606 → made their first commit to this issue’s fork.
Is there still anything that needs to be done?
There are a few changes in MR 37 that still need to land. Besides that, what more needs to be done before official D11 support for v3 is available and new 3.x release tagged?
jeremy1606 → changed the visibility of the branch 3296968-automated-drupal-10 to hidden.