- Issue created by @phenaproxima
- ๐ฉ๐ชGermany jurgenhaas Gottmadingen
When getting around to this, please only require
drupal/gin
as Gin itself already contains the gint_toolbar dependency. - First commit to issue fork.
- First commit to issue fork.
- ๐บ๐ธUnited States phenaproxima Massachusetts
As per Jurgenโs comment, the Gin Toolbar dependency should be removed. Looks right to me otherwise.
- ๐ณ๐ฎNicaragua jeremy1606
By accident two empty commits were sent. But I managed to update the two modules with composer and they are already in versions 4.0.0 and 2.0.0 respectively.
- ๐บ๐ธUnited States phenaproxima Massachusetts
The branch doesn't look correct yet, though. Can you please implement what @jurgenhaas asked for in #2, which calls for removing the dependency on Gin Toolbar, and only relying on Gin?
- ๐ณ๐ฎNicaragua jeremy1606
Of course. I've already done it. Can you check it please and tell me if it's ok now?
- ๐บ๐ธUnited States phenaproxima Massachusetts
That looks good, but you need to open a merge request so that the tests run and I have something to merge! :)
Here's some (admittedly not very good) documentation on how to do that, if you're unfamiliar with the process: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... โ . I tried to do it just now but it didn't work for some reason.
- ๐บ๐ธUnited States phenaproxima Massachusetts
If you also don't see a "Create merge request" button in GitLab, maybe try pushing a differently-named branch to this issue fork?
In theory the branch name shouldn't matter, though, so I'm not sure what's going on.
You don't need to run the tests locally. They are will automatically run if you create a merge request in the GitLab UI.
(Also, please do not delete the issue summary when you post comments. :) Maybe refresh the page before posting your next comment, just so that any emptied form fields are refreshed?)
- ๐บ๐ธUnited States phenaproxima Massachusetts
Magnificent - thank you! Will merge when tests pass.
- ๐บ๐ธUnited States phenaproxima Massachusetts
Crediting @heddn for some behind-the-scenes mentoring work. :)
-
phenaproxima โ
committed ff3ed3d0 on 1.x authored by
jeremy1606 โ
Issue #3495287 by jeremy1606, jurgenhaas, heddn: Update Gin and Gin...
-
phenaproxima โ
committed ff3ed3d0 on 1.x authored by
jeremy1606 โ
-
phenaproxima โ
committed 063dbe40 on 1.0.x authored by
jeremy1606 โ
Issue #3495287 by jeremy1606, jurgenhaas, heddn: Update Gin and Gin...
-
phenaproxima โ
committed 063dbe40 on 1.0.x authored by
jeremy1606 โ
Automatically closed - issue fixed for 2 weeks with no activity.