- Status changed to Needs review
about 2 years ago 9:02am 18 January 2023 - Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs work
about 2 years ago 6:00pm 31 January 2023 - heddn Nicaragua
Fixes to PHPCS are great. But automated fixes aren't. Please review the output from phpcbf and fix any obvious issues. Also, the default branch here is 6.x now. So switching branches.
- First commit to issue fork.
- Assigned to vishaljd
- 🇮🇳India Akram Khan Cuttack, Odisha
Added updated patch against 6.0.x and address #5
- Status changed to Needs review
about 2 years ago 5:21am 27 February 2023 - Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 3:44pm 1 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 1 year ago 10:06am 29 June 2023 - Status changed to Needs work
about 1 year ago 2:20am 3 January 2024 - 🇵🇭Philippines paraderojether
Hi vishaljd,
I reviewed MR!72, applied against Migrate Plus 6.0.x-dev with Drupal core version 10.1.7 and there are still phpcs errors and warnings shown below:
FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_example/migrate_example_setup/migrate_example_setup.install -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_json_example/migrate_json_example.install -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_plus.module -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/data_fetcher/HttpTest.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_plus\AuthenticationPluginInterface. ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/data_fetcher/FileTest.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\MigrateException. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Unit/process/StrReplaceTest.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 14 ERRORS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------------------------------ 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 33 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 34 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 47 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 48 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 58 | ERROR | [x] Expected 1 blank line after function; 2 found 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 62 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 63 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 73 | ERROR | [x] Expected 1 blank line after function; 2 found 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 77 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 78 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate/process/EntityValueTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------ 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\language\Entity\ConfigurableLanguage. ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/README.md ---------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES ---------------------------------------------------------------------------------------------------- 33 | WARNING | Line exceeds 80 characters; contains 123 characters 39 | WARNING | Line exceeds 80 characters; contains 147 characters 44 | WARNING | Line exceeds 80 characters; contains 154 characters 45 | WARNING | Line exceeds 80 characters; contains 129 characters 46 | WARNING | Line exceeds 80 characters; contains 91 characters 48 | WARNING | Line exceeds 80 characters; contains 136 characters 50 | WARNING | Line exceeds 80 characters; contains 153 characters 61 | WARNING | Line exceeds 80 characters; contains 148 characters 62 | WARNING | Line exceeds 80 characters; contains 347 characters 69 | WARNING | Line exceeds 80 characters; contains 108 characters 71 | WARNING | Line exceeds 80 characters; contains 119 characters 72 | WARNING | Line exceeds 80 characters; contains 114 characters 76 | WARNING | Line exceeds 80 characters; contains 102 characters 78 | WARNING | Line exceeds 80 characters; contains 161 characters 79 | WARNING | Line exceeds 80 characters; contains 171 characters 96 | WARNING | Line exceeds 80 characters; contains 176 characters 97 | WARNING | Line exceeds 80 characters; contains 111 characters 104 | WARNING | Line exceeds 80 characters; contains 88 characters 105 | WARNING | Line exceeds 80 characters; contains 90 characters ---------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_example_advanced/migrate_example_advanced.install ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/migrate_plus.install ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 21 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/AuthenticationPluginManager.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_fetcher/File.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\MigrateException. ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_fetcher/Http.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate_plus\AuthenticationPluginInterface. ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/source/Url.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\Plugin\MigrationInterface. ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/EntityValue.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface. ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/StrReplace.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 128 | ERROR | [x] Expected 1 space after IF keyword; 0 found 129 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/Transpose.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\migrate\ProcessPluginBase. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/Plugin/migrate/process/DomApplyStyles.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 143 | ERROR | [x] Use "elseif" in place of "else if" ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/DataParserPluginManager.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/migrate_plus/src/DataFetcherPluginManager.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- Time: 2.23 secs; Memory: 16MBKindly check and advise, please.
Thank you. - Assigned to Anita verma
- last update
about 1 year ago 189 pass, 2 fail - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:52am 3 January 2024 - 🇮🇳India Anita verma
I fixed all errors and warnings, Kindly review,
Thanks. - Status changed to Needs work
about 1 year ago 2:50pm 7 January 2024 - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 4:30pm 18 January 2024 - First commit to issue fork.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
liam morland → made their first commit to this issue’s fork.