πŸ‡΅πŸ‡ΉPortugal @guilherme-lima-almeida

Lisbon
Account created on 10 January 2020, about 5 years ago
  • Drupal Development at MerkleΒ 
#

Merge Requests

Recent comments

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hello avpaderno,

I have already been permitted for grevil as maintainer.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi @Daniel Korte,

I can help maintain this module if you want.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi @mageshbcet1,

OpenSocial 11.11.4 requires "drupal/core": "~9.5" and "drupal/lazy": "3.11.0" which isn't compatible with Drupal 10 ( https://www.drupal.org/project/lazy/releases/8.x-3.11 β†’ ).
So I think the best approach is to update the OpenSocial first and then update Drupal Core, since OpenSocial 12.0.0 requires "drupal/core": "~10.0.0" and "drupal/lazy": "3.12.0" which is compatible with Drupal 10.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi everyone,

With:

  • Drupal: 10.0.11
  • Redirect: 8.x-1.9

The patch #149 works for me and the URL redirect is added to either node's edit form.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi there,

Here is the patch to solve this problem.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Works well for me, and it's important to add this patch to version 2.0.0 otherwise this version doesn't work. At least for me.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi @TolstoyDotCom,

Despite what you said, I'll create a patch even if it's just me using it. This way, in future updates, I can keep track of the changes on this issue.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi Andrey Proh,

I added dependency injection and added the validateForm method to check if the routes the user insert exists.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi Dharti Patel,

Already approved your merge request.

Thanks for the help.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi thejimbirch and mikohl,

Already merged the changes to the dev branch.

Thanks for the help.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

guilherme-lima-almeida β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi there refringe,

X-Powered-By is not removed, because the header is not part of the response object, given that it is not set by the Symfony application but by PHP itself. And I think the same thing applies to the Server header.

I don't know how to remove the Server header but for the X-Powered-By you can alter your php.ini to fix it:

expose_php = Off

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Sorry nayana_mvr,

I was using Drupal Standard on PHPCS and not DrupalPractice. I've already made the changes pointed out by DrupalPractice.

Thanks for the help, everyone.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi Kamlesh Kishor Jha,

I'm still getting these errors with the PHPCS. I'll fix this on your fork and approve the merge request.

---------------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 14 LINES
---------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
  5 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  6 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found
  7 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------

Time: 78ms; Memory: 8MB
πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

guilherme-lima-almeida β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi vistree,

Can you give me more information? I tried to replicate the problem and I didn't have the problem with the strip slash from the path.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi annmarysruthy,

I already approved the merge request and create a new release.

Thanks for the help.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Here's the patch to solve the problem. Needs review.

πŸ‡΅πŸ‡ΉPortugal guilherme-lima-almeida Lisbon

Hi @bvoynick,

Already merge the changes to 8.x-2.x-dev.

Thanks for the fix.

Production build 0.71.5 2024