Contrib.social

Module lists Drupal 8 & 9.0 as compatible, but they are not

Open on Drupal.org →
Created on 10 February 2023, about 2 years ago
Updated 21 February 2023, about 2 years ago

Problem/Motivation

Issue #3289933 added compatibility with Drupal 10 to the Dev branch. Among the deprecations addressed was this one: Usage of symfony-cmf/routing dependency deprecated →

As specified in that change record, the new Drupal-specific RouteObjectInterface was introduced in Drupal 9.1. This means that the TablefieldItem class is no longer compatible with Drupal 9.0.x and below, it will error in its isEmpty() method.

Proposed resolution

The versions of Drupal core that cannot be supported with this D10-compatible code are all already End of Life for some time now. The nice and easy resolution is to raise the required core version appropriately.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States bvoynick

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @bvoynick
  • @bvoynick opened merge request.
  • Status changed to Needs review about 2 years ago
  • Comment about 2 years ago →
    🇺🇸United States bvoynick
  • Status changed to Needs work about 2 years ago
  • Comment about 2 years ago →
    🇺🇸United States pcate

    The upgrade status modules lists the following additional change needed:

    modules/contrib/tablefield/src/Plugin/Field/FieldType/TablefieldItem.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 223  │ Symfony\Cmf\Component\Routing\RouteObjectInterface::ROUTE_NA │
│ manually │      │ ME is deprecated and removed in Drupal 10. Use               │
│          │      │ Drupal\Core\Routing\RouteObjectInterface::ROUTE_NAME         │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
  • Status changed to Needs review about 2 years ago
  • Comment about 2 years ago →
    🇺🇸United States bvoynick

    @PCate double check that you are using the latest dev version, rather than the latest release.

  • Comment about 2 years ago →
    System Message
  • Comment about 2 years ago →
    🇵🇹Portugal guilherme-lima-almeida Lisbon

    Hi @bvoynick,

    Already merge the changes to 8.x-2.x-dev.

    Thanks for the fix.

  • Status changed to Fixed about 2 years ago
  • Comment about 2 years ago →
    🇵🇹Portugal guilherme-lima-almeida Lisbon
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024