Image style generation no longer works for non-local drivers in

Attaching a patch for use with composer.

We had the same problem on an islandora project using fedora driver. The #4 patch fixed the issue. Thanks!

I had the same issue with S3 and the #4 patch fixed it. Thanks.

Tried #4 against 2.3.x using S3 but we still have issues. It looks like the `flysystem.image_style_redirect.serve` route is still only added for local drivers, and so when using the S3 scheme for example, it errors with a RouteNotFoundException when trying to generate a style.

I have tried defining the redirect routes outside of the local driver check, which resolves the exception, however the temporary image style does not appear to be working either - it returns the URL of the external resource that is still in the process of being uploaded.

I'm not sure how the patch is working for other people unless running an older version of the flysystem_s3 module that still uses the deprecated image generation method.

For reference, the issue I was having was also picked up in the flysystem_s3 module, and they have reverted to the old generation method until it has been figured out - https://www.drupal.org/project/flysystem_s3/issues/3430648 📌 Automated Drupal 11 compatibility fixes for flysystem_s3 Needs review

At the very least this needs to be an MR and I believe there are a few aspects missing here, including image derivative token generation. Working on this.

Moving this to 2.3.x so it can also be backported.

Worked on this and applied to both 2.3.x and 2.2.x. The latter required a bit of massaging to the GitLab CI configuration for the test suite to pass, as well. Decided to just fix here instead of a separate issue. The S3 (and other) modules will need updated to take advantage of this. As noted in #3430648-44: Automated Drupal 11 compatibility fixes for flysystem_s3 → this should allow for a new major version of flysystem_s3 as well. Will tag a new release shortly after committing some other RTBC issues.

I hate to keep coming back to this with more issues, but I think there might be something else missing in these changes.

For local drivers, where the controller is "Drupal\image\Controller\ImageStyleDownloadController::deliver", the "scheme" argument was previously being passed through - however this has now been removed, resulting in an exception when generating image styles. Adding it back in fixes the issue for me.

Re: #18, no apologies necessary at all. This is my fault. Fix incoming. Thank you!

Tagged an rc2 on both branches.

Automatically closed - issue fixed for 2 weeks with no activity.