🇩🇪Germany @ChristianAdamski

Nice

Merged

Thanks! :)

1.) Currently issues with some newly added Google Maps based tests. They work/not randomly.
2.) Without having looked at the code, I think there are several spots where ModuleHandler is used instead of the Interface.
3.) My wife lived 6 years in Shanghai until March. We will come to Shanghai next year anyway, so will pick you up on your offer :)
4.) If you need any support, reach out. Would love to work in connection with Shanghai, my wife misses it quite a bit :)

Fair enough, started merging.

Also: I was in Shanghai several months last year/early this year and found no Drupal events happening at all. Would have loved to visit you guys :)

Which map provider are you using in you project?

Hey,

sorry, I'm afraid this module is only a hobby of mine. Sadly no outside support to give it more attention.

Anyway: I do notice that Google Maps can show the house numbers, if you zoom in far. I also notice, this does not seem to happen on your link. But any idea why? Or how to improve that behavior?

Whats the desired functionality to be added here? What code would need to change?

Is this an issue with geolocation, or with the respective geocoder? Does not sound like geolocation is really responsible?

I don't get it...

This is way too specific, sorry. People could enter there anything. Sorry.

I think this is a views question, not a geolocation question. If it works with views in general, it should also work with geolocation.

This works now in principal in v4. Just the numer of tile providers has to increase a lot.

This is now pretty well supported in v4

Already done.

Sorry, took a while to get to this. Stylelint is already happy in the meantime.

Is this well enough tested to be merged? It is separately fixed in v4.

v4 already PHPStan compatible

ChristianAdamski → changed the visibility of the branch 3214200-client-location-input to hidden.

Note to self: this is principally unsolvable in the forseeable future. AJAX Views replaces the views content div, including the container with map.
The Geolocation JS intervenes there, and moves the map container over to the new content before replacement, thus preserving it. This destroys the fullscreen anchored DIV though, thus ending fullscreen. This is most likely a security measure of the browser.

Leaving it open in case a future development allows to do something else.

Seems to work fine now in v4. Closing as outdated, hopefully correctly

Duplicate of and solved in 🐛 Search as I move the map drops multi-value exposed filter values Fixed in v4

Thanks!

Fixed in v4

Tested in v4 and works. Did not test in v3..

There is a " No location has been selected yet for required field Geolocation Demo Single. " message at the top. Might have been added after this ticket was created.

Just tested with 6 markers at the same location, works fine.

ChristianAdamski → created an issue.

Thanks!

Also merge to v4

ChristianAdamski → created an issue.

ChristianAdamski → created an issue.

Waiting on upstream issues.

ChristianAdamski → created an issue.

ChristianAdamski → changed the visibility of the branch 3333036-search-api to hidden.

I f*$§%§$%ng hate this new bizarro merge fork weirdo workflow. Creating a new issue instead.

ChristianAdamski → changed the visibility of the branch 3333036-integration-with-views to hidden.

Leaflet Marker Clusterer is now automatically tested.

Thanks!

Very simple typo. Disabled all featured completly.

More interesting questions: why didn't I notice?

Need more tests..

Thanks!

ChristianAdamski → made their first commit to this issue’s fork.

ChristianAdamski → created an issue.

ChristianAdamski → created an issue.

ChristianAdamski → created an issue.

As the maintainer I suggest:

- Site Structure
- Integrations
- Content Display

Nobody has come up with an implementation, so I'm gonna close this.

This just feels out of place for this module. I see in your example you can query by lat lng, but thats not really the same.

I think this would be better as a stand alone module, potentially integrating directly with address module.

This got added at some point to 4.x

Image file fields, to be precise.

Ok, you can now use images as geodata source in latest v4-dev.

ChristianAdamski → created an issue.

Already fixed in 🐛 Geolocation leaflet library definitions license is missing URL Fixed

Thanks!

@tzatziki I'm pretty sure I credited you, but it does not seem to take. Let's see if it just takes a moment.

ChristianAdamski → created an issue.

Features to check:
- clusterer
- spiderfier
- MarkerInfoWindow
- MarkerIcon
- MarkerLabel
- MarkerOpacity

Thank you!

Brilliant idea!

Minimally altered JS. Only thing left is adding conditional_viewport_threshold to config/schema/geolocation.data_types.schema.yml as float to geolocation_map_provder section.

Not at my PC right now, can't do it myself

ChristianAdamski → made their first commit to this issue’s fork.

Thanks!