🇩🇪Germany @christianadamski

christianadamski → made their first commit to this issue’s fork.

Removed the conflicting files and added a dependency on search_api_location instead.

christianadamski → created an issue.

I do not have an answer ready, but the by API you mean the PHP side? Like in the geolocaitonGooglePlaceAPI.php Plugin?

That one calls https://maps.googleapis.com/maps/api/place/details/json under the hood.

The widget works with the JS API instead. File geolocation-google-places-api-geocoder.js in v3. Calling JS google.maps.places.PlacesService.getDetails().

I assume these give different results? Or they determine different "Place ID"?

Can you test that?

I used this issue to fix a lot of PHP issues, which is fine.

But the issue you point out is a bit weirder. The files in questions are just copies of https://www.drupal.org/project/search_api_location →

I think they should simply be deleted and instead that module required? Can you test that?

christianadamski → made their first commit to this issue’s fork.

Applied midly altered. Thanks!

Also added a D10 pass to CI to catch similar issues automatically.

christianadamski → made their first commit to this issue’s fork.

There are several such issues in v3. See phpstan part in the weekly CI runs.

v3 won't stay past D11.

christianadamski → created an issue.

christianadamski → created an issue.

https://www.drupal.org/project/geolocation/issues/3522323 ✨ Remove dependency on jQuery Active

(This issue is less than a month old. Please search before posting issues, its easier for everyone.)

Hidden Map/Layer Features!

@todo:
- Point/Marker support
- Google Maps
- Shapes in Yandex/Baidu/?

Can you upload a sample file and 1-2 screenshots? And describe what a better solution would look like?

Regarding SearchAPI, there is a gap I think. There is SearchAPI support for Geolocation field and geometry, but GPX is its own entity type. So it would probably need separate SearchAPI integration.

Hey,

it's just me. In my spare time. Just to manage expectations.

For each error, please open an issue with the error description and maybe screenshots.

As for GPX, its conceptually hard. A GPX file can contain any amount of trails with any amount or tracks waypoints etc. So they are stored in a separate entity type. The GPX file field just keeps a reference to the uploaded data.

If you have more specific questions, please ask.

The solution is this:

scripts/at.responsiveLists.js

line first & last

(function ($, Drupal, window) {
})(jQuery, Drupal, window);

to

(function ($, Drupal, window, once) {
})(jQuery, Drupal, window, once);

line 46

list.once().each(init);

to

$(once('at-responsive-list', list)).each(init);

I can't provide patch or MR as the package.json toolchain doesn't work anymore and I can't minimize the JS with that.

christianadamski → created an issue.

This now works in v4. v3 is only getting bugfixes at this point.

Interaction with geometry objects now works in formatter and views in v4. v3 is not getting worked on beyond bugfixes.

christianadamski → created an issue.

Don't worry, you're absolutely welcome :)

Shouldn't the latter happen anyway?
I mean, if you ignore geolocation and just imagine a regular list view; shouldn't the filter only show relevant entries?

christianadamski → changed the visibility of the branch 3325926-marker-click-pop to hidden.

christianadamski → changed the visibility of the branch 3325926-marker-click-pop to active.

christianadamski → changed the visibility of the branch 3325926-marker-click-pop to hidden.

christianadamski → made their first commit to this issue’s fork.

I think the underlying issue is, that geolocation currently doesn't tell you, that points are not treated as shapes, but as locations/markers.

Closing in favor of 📌 Unify fit locations & fit shapes Active

christianadamski → created an issue.

christianadamski → created an issue.

At some point this must have been fixed in v4. Cannot reproduce anymore.

Of course heavily outdated by now, but just for the record:

In geolocation v4 putting

<button href="#" onclick="alert('Welt');">Hallo</button>

into a node and displaying that in the popup on a marker works perferctly fine.

christianadamski → created an issue.

Eh, what now? Z-Index of what? Icon? Marker? I honestly don't know. What specifically needs the z-index?

christianadamski → made their first commit to this issue’s fork.

Cannot reproduce. Nobody else seems to have this issue. Will close.

Nobody interested. So just remove Bing maps.

Nobody else seems to run into this. Works fine here. Might be project specific.

Could not reproduce..

Nobody else seems to experience this. Might be project specific. Closing.

Handled in MR 100, and already fixed there. Merge soon.

https://git.drupalcode.org/project/geolocation/-/merge_requests/100

Already handled in MR 100. Will be merged soon

https://git.drupalcode.org/project/geolocation/-/merge_requests/100

New Center option added

Wait, you want to the map to contiously follow the user? That's a completely different use-case.

I went locally from a clean v3 to v4, and the maps were correctly centered on the markers. So I cannot reproduce this locally.

Hey,

I understand the issue, but chose a different approach. Client location marker will only be set once location is available.

christianadamski → made their first commit to this issue’s fork.

christianadamski → made their first commit to this issue’s fork.

Merged!

Merged!

Thanks for finding!

christianadamski → made their first commit to this issue’s fork.

I might add, jQuery is replaced in v4. v3 still depends on jQuery elements.

Works fine here..

I'd suggest to release this as v3 (?)

Also tested locally manually. Works fine.

- Merged MR fixes
- Fixed Testing issues
- Brought code to PHPStan level 6
- Drupal coder Coding Style fixes
- Disabled CSPell check

christianadamski → made their first commit to this issue’s fork.

jQuery is already removed. Only leftovers are by core. Autocomplete widget & ajaxComplete events.

christianadamski → created an issue.

christianadamski → created an issue.

I just logged out and tried to access an /admin page and was not redirected...

That did not work. I don't know how to build this. I exported it as is.

I don't know how to build this workflow. Just exchange to event?

christianadamski → created an issue.

Well, can you look up, if Tianditu is officially available worldwide now? I remember a year ago, I could not access there website, now I can...

If it really and officially and permanently is available everywhere, we could merge it back to geolocation.

I may have the same problem as with Baidu though: I cannot get map keys. For Baidu you need a chinese commercial something number. I don't have that obviously.

christianadamski → created an issue.

Please remove or explain the placeId usage and the sessionToken

This change does a lot more though...

Seems outdated? Nobody else came forward with a problem..

I had to alter it a bit..

Thanks!!

christianadamski → made their first commit to this issue’s fork.

christianadamski → created an issue.

There are Formatters for the address field available in v3 and v4...?

christianadamski → created an issue.