- Issue created by @f1mishutka
- @f1mishutka opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:59pm 22 February 2023 - π§πΎBelarus f1mishutka Minsk
Changed priority to Major because this could be show stopper for projects under Drupal 10
- Status changed to RTBC
over 1 year ago 8:11pm 30 March 2023 - πΊπΈUnited States Chris Matthews
Manually tested the patch generated from the merge request and it provides a temporary fix for this issue so taking the liberty to mark as RTBC. @shelane @wundo, would you be able to commit merge request !23 and ideally tag a new 8.x-3.28 release?
- πΊπΈUnited States Chris Matthews
Here is a patch that includes jquery dependency updates as well:
THISmodal.jquery.ui.bridge: js/modal.jquery.ui.bridge.js: {} dependencies: - bootstrap/modal - core/jquery.ui - core/jquery.ui.widget - core/jquery.ui.draggable - core/jquery.ui.mouse - core/jquery.ui.position - core/jquery.ui.resizable
TO THIS
modal.jquery.ui.bridge: js/modal.jquery.ui.bridge.js: {} dependencies: - jquery_ui/jquery_ui - jquery_ui_draggable/jquery_ui_draggable - jquery_ui_resizable/jquery_ui_resizable
For reference: https://www.drupal.org/node/3067969 β
- πΊπΈUnited States shelane
I will need to update dependencies in composer and do a hook to make sure those dependencies are enabled.
- π§πΎBelarus f1mishutka Minsk
As I understand jQuery UI stays in Drupal 10 core. So there is no need to rely on jquery_ui module.
So there is no need to second patch with `core/jquery.ui` replaced to `jquery_ui/jquery_ui`We are running bootstrap theme under Drupal 10 for two month already with just patch from merge request with no issues at all.
My proposal is to merge it as simple as it is in merge request. This is enough quick-fix for people can use it already under Drupal 10 without patches) and then concentrate efforts on issue #3343712 as a long-term solution for Drupal 10.1+
- πΊπΈUnited States Chris Matthews
Yeah, I do agree @f1mishutka. Good call.
-
shelane β
committed 30cd4db2 on 8.x-3.x authored by
f1mishutka β
Issue #3343708 by f1mishutka, Chris Matthews: Underscore.js library is...
-
shelane β
committed 30cd4db2 on 8.x-3.x authored by
f1mishutka β
- Status changed to Fixed
over 1 year ago 3:29pm 17 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.