- @f1mishutka opened merge request.
- Merge request !19Issue #3171604: '#empty_value', '#empty_option' does not work properly β (Open) created by f1mishutka
- Status changed to Needs review
about 2 years ago 7:17am 14 February 2023 - π¬π§United Kingdom jonathanshaw Stroud, UK
Version should be set to dev version.
- π©πͺGermany chr.fritsch π©πͺπͺπΊπ
chr.fritsch β made their first commit to this issueβs fork.
- Status changed to RTBC
almost 2 years ago 6:13am 11 May 2023 - π§πΎBelarus f1mishutka Minsk
Any chance to have this merged? It is almost 3 years of this bug already :(
Fix in MR is very simple. And it works for years in at least 8 projects for us.
Thanks in advance!
- πΊπΈUnited States ccjjmartin Austin, TX
Thanks for this contribution, I can confirm this fixed my issue also. I was specifically using the empty option setting, looking in the description I see that empty value was also set to -1 and when I attempted that on my environment I got an error about an invalid option set. So I just removed that and only set the empty option and the patch works great.
- π§πΎBelarus f1mishutka Minsk
Rebased MR!19 on latest 8.x-1.x upstream branch.
Could you please merge it? It is years already...
Thanks. - π§πΎBelarus f1mishutka Minsk
MR35 is RTB. Why was MR19 created?
/irony/ You do notice here that 19 is little bit lower than 35, yeah?
So answer to you question: MR19 was created 2023-02-14 to fix this issue.
And we asking to merge it for almost two years already.P.S.: Correct question would be why MR35 was created 2024-05-07 with exactly same changes? :)
- πΊπΈUnited States SocialNicheGuru
You are right. it is early here and no coffee. please forgive me.
I did mean it the other way aroundWhy was MR35 created when MR19 was already RTB (sorry about that)?
- π§πΎBelarus f1mishutka Minsk
God bless coffee (any time of a day)! :)
Since there is no difference between MR19 and MR35 merging any of them will make us all happy.And happy New Year of course! :)
- π¬π§United Kingdom jonathanshaw Stroud, UK
MR 19 fails CI. MR19 also contains an indentation error that is fixed in MR 35.
- π§πΎBelarus f1mishutka Minsk
MR 19 fails CI. MR19 also contains an indentation error that is fixed in MR 35.
They are both fail CI. And it is because of changes in upstream branch and not because of changes in this MRs. And this indentation error was fixed in MR19 already.
Anyway creating new MR is not a way to correct something in existing one as I understand open source in general...
But one more time: sure there is no difference which MR will be merged since they are both identical. Please merge any of them! Thanks.
- π§πΎBelarus f1mishutka Minsk
f1mishutka β changed the visibility of the branch master to hidden.
- π§πΎBelarus f1mishutka Minsk
f1mishutka β changed the visibility of the branch 3171604-empty to hidden.
- π§πΎBelarus f1mishutka Minsk
Created new MR45 for module version 2.0 (branch 2.x) if anybody needs diff to apply patch.
Still hoping it will be merged one day...