- πΊπΈUnited States angrytoast PNW
A number of changes from the last patch in #17:
- Renumber the update hook from 8105 to 8202 since this is targeting the 8.x-2.x branch and there is already a 8201
- Ensure that the
entity_print
config is installed where necessary and updated with necessary entity type ids for tests - Remove an odd injected
$this->stringTranslation
inEntityPrintPermissions
as is it never used directly and the string translation functionality is already covered byuse StringTranslationTrait
- Fix up a couple of code standard recommendations
This doesn't include any net new tests. Just trying to get it to a passing state against the existing tests.
- Status changed to Needs review
almost 2 years ago 4:54am 29 July 2023 - last update
almost 2 years ago 53 pass, 2 fail The last submitted patch, 20: entity_print-configure-enable-types-2928222-20.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
almost 2 years ago 54 pass - πΊπΈUnited States angrytoast PNW
Continuing work from #20, interdiff is still against #17.
- Merge request !79Issue #2928222 by flocondetoile, catch, angrytoast, joseph.olstad, benjy,... β (Open) created by joseph.olstad
- π¨π¦Canada joseph.olstad
all green, had to fix a deprecation
https://git.drupalcode.org/issue/entity_print-2928222/-/pipelines/547158
- π¨π¦Canada joseph.olstad
RTBC
This solution is smaller than π Extra fields added to all entity types, causing noise in exported config Active
- π¨π¦Canada joseph.olstad
Actually, reviewed the code a bit more, needs more review, will review also the other proposed solution.
- π¨π¦Canada joseph.olstad
This merge request above is very good, I believe it is disruptive enough however to warrant a 3.0.x release.
The release notes for 3.0.x should mention the need to configure the enabled entity_types.