🇩🇪Germany @DiDebru

Thanks for the patch.
In our case it happens if we send a webform graphql mutation with a pdf attached.

didebru → created an issue.

didebru → created an issue.

I miss an example on how to handle file uploads now.

Example of old working solution.

$scheme = $element['#uri_scheme'] ?? 'private';
    $destination = $scheme . '://webform/' . $webform->id() . '/_sid_';

    $filename = ContentDispositionFilenameParser::parseFilename($request);

    // Check the destination file path is writable.
    if (!$this->fileSystem->prepareDirectory($destination, FileSystemInterface::CREATE_DIRECTORY)) {
      return new ModifiedResourceResponse([
        'error' => 'Destination file path is not writable.',
      ]);
    }

    $hash = bin2hex(random_bytes(18));

    // Create the file.
    $file_uri = "{$destination}/{$hash}-{$filename}";

    $temp_file_path = $this->streamUploadData();

    $file_uri = $this->fileSystem->getDestinationFilename($file_uri, FileExists::Rename);

    // Lock based on the prepared file URI.
    $lock_id = $this->generateLockIdFromFileUri($file_uri);

    if (!$this->lock->acquire($lock_id)) {
      return new ModifiedResourceResponse([
        'error' => 'Failed to save file.',
      ]);
    }

    // Begin building file entity.
    $file = File::create([]);
    $file->setOwnerId($this->currentUser->id());
    $file->setFilename($filename);
    if ($this->mimeTypeGuesser instanceof MimeTypeGuesserInterface) {
      $file->setMimeType($this->mimeTypeGuesser->guessMimeType($filename));
    }
    else {
      $file->setMimeType($this->mimeTypeGuesser->guess($filename));
      @trigger_error('\Symfony\Component\HttpFoundation\File\MimeType\MimeTypeGuesserInterface is deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Implement \Symfony\Component\Mime\MimeTypeGuesserInterface instead. See https://www.drupal.org/node/3133341', E_USER_DEPRECATED);
    }

    $validators = [];
    // Validate allowed extensions.
    if (!empty($element['#file_extensions'])) {
      $allowed_extensions = $element['#file_extensions'];
    }
    else {
      $file_type = str_replace('webform_', '', $element['#type']);
      // @phpstan-ignore-next-line
      $allowed_extensions = \Drupal::config('webform.settings')->get("file.default_{$file_type}_extensions");
    }
    $validators['file_validate_extensions'] = [$allowed_extensions];

    $file->setFileUri($temp_file_path);
    // Set the size. This is done in File::preSave() but we validate the file
    // before it is saved.
    $file->setSize(@filesize($temp_file_path));

    // Cap the upload size according to the PHP limit.
    $max_filesize = Bytes::toNumber(Environment::getUploadMaxSize());
    if (!empty($element['#max_filesize'])) {
      $max_filesize = min($max_filesize, Bytes::toNumber($element['#max_filesize']) * 1024 * 1024);
    }
    $validators['file_validate_size'] = [$max_filesize];

    // Validate the file against field-level validators first while the file is
    // still a temporary file. Validation is split up in 2 steps to be the same
    // as in _file_save_upload_single().
    // For backwards compatibility this part is copied from ::validate() to
    // leave that method behavior unchanged.
    // @todo Improve this with a file uploader service in
    //   https://www.drupal.org/project/drupal/issues/2940383
    $validators['file_validate_name_length'] = [];

    $errors = $this->fileValidator->validate($file, $validators);

    if (!empty($errors)) {
      $message = "Unprocessable Entity: file validation failed.\n";
      $message .= implode("\n", array_map([
        PlainTextOutput::class,
        'renderFromHtml',
      ], $errors));
      return new ModifiedResourceResponse([
        'error' => $message,
      ]);
    }

    $file->setFileUri($file_uri);
    // Move the file to the correct location after validation. Use
    // FileSystemInterface::EXISTS_ERROR as the file location has already been
    // determined above in FileSystem::getDestinationFilename().
    try {
      $this->fileSystem->move($temp_file_path, $file_uri, FileSystemInterface::EXISTS_ERROR);
    }
    catch (FileException $e) {
      return new ModifiedResourceResponse([
        'error' => 'Temporary file could not be moved to file location',
      ]);
    }

    // Second step of the validation on the file object itself now.
    $this->resourceValidate($file);

    $file->save();

    $this->lock->release($lock_id);

How can this be done with the new logic?

didebru → created an issue.

Solved with https://git.drupalcode.org/project/commerce_saferpay/-/merge_requests/5

I made another MR to resolve the conflicts with https://www.drupal.org/i/3115858 → https://git.drupalcode.org/project/commerce_saferpay/-/merge_requests/5

DiDebru → made their first commit to this issue’s fork.

DiDebru → created an issue.

Thanks for the patch works like a charm.

I can see that the complete form has the library attached but the pane form does not.

Before I added the line and have xdebug on multiple instances spin up.

After I added the line only 1 spin up.

So yeah believe it or not this should be added also to pane forms.

Ok strange because it didn't work.
But it did after I added the library.

DiDebru → created an issue.

Changes looking good tested and works fine thanks for the patch!
Setting to RTBC

Patch did the opposite in my case.

Correct use statements

It maybe sounds strange but for me it was that I need to rehash the password for the basic auth user.

DiDebru → created an issue.

Custom patch caused this closing.

DiDebru → created an issue.

DiDebru → created an issue.

Added missing path resolver service in services yml.

DiDebru → made their first commit to this issue’s fork.

DiDebru → made their first commit to this issue’s fork.

DiDebru → made their first commit to this issue’s fork.

DiDebru → made their first commit to this issue’s fork.

DiDebru → created an issue.

DiDebru → made their first commit to this issue’s fork.

DiDebru → created an issue. See original summary → .

phpstan false positive.

DiDebru → created an issue.

DiDebru → created an issue.

I got this error after upgrading from 9.4 to 10.1.
I did run all db updates and ended up with an empty setting en/admin/config/content/rabbit-hole and the variable was always null.
The patch did not solve this but I was able to solve this by overriding the variable with an empty array than I did the config saved removed the workaround and my site works again.

DiDebru → made their first commit to this issue’s fork.

Set this to RTBC code looks good and it solves the issue.

DiDebru → made their first commit to this issue’s fork.

Patch works setting to RTBC.

DiDebru → made their first commit to this issue’s fork.

DiDebru → created an issue.

DiDebru → created an issue.

DiDebru → made their first commit to this issue’s fork.

Custom patch issue.

DiDebru → created an issue.

We are also facing this issue patch #29 solved it.

I know this needs steps to reproduce but this property can be null and needs to be treated like that. Either by this patch or by allowing it to be null.

DiDebru → created an issue.

Please also be aware of this:
https://www.drupal.org/node/3322420 →

Still works.

DiDebru → created an issue.

Fix fatal error:
Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "revision_id" for route "entity_print.revision.view" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 206 of core/lib/Drupal/Core/Routing/UrlGenerator.php).

This works for me!
Thanks!

DiDebru → created an issue.

Sorry figured it out there was a placeholder module in our custom modules that has overridden the submodule.
Ticket can be closed as works as designed :facepalm:

I am not sure about the exact circumstances.
The main and submodule are enabled. But I keep getting:
LogicException: Missing type WebformElementStates. in Drupal\graphql\Plugin\GraphQL\Schemas\SchemaPluginBase->getType() (line 421 of /app/docroot/modules/contrib/graphql/src/Plugin/GraphQL/Schemas/SchemaPluginBase.php)

And for me it's working fine when I merge the sub and the main module.
I know it is odd.

I've updated the MR to include dependent error messages also doing some sanity checks and take the coupon start end date into account.

Sorry I didn't see you started to work on this I have prepared a solution in another branch which works fine for me.

Thanks for your work but the issue is a bit more complex than this.
We have to check all we can check without the user and order context.
Also we should prompt an error message if the code is invalid.

DiDebru → created an issue.

Same Issue for me as mentioned in #5.
Also -1 for me maintain annotations is quite a lot of work.

DiDebru → created an issue.

Good question but unfortunately I don't have an answer yet but with that patch it does not happen.

I had to update the package correctly all fine :)

DiDebru → created an issue.

Patch #3 does not work with D10 because of method name change isMasterRequest to isMainRequest.
Please review the MR.

DiDebru → created an issue.

DiDebru → made their first commit to this issue’s fork.

DiDebru → created an issue.

DiDebru → created an issue.

DiDebru → created an issue.

Reroll against 2.0,x.

DiDebru → made their first commit to this issue’s fork.

Reviewed +RTBC from my point of view.

DiDebru → created an issue.

smustgrave → credited DiDebru → .

Why not cast the parameter to (string) in Html.php:386 and Html.php:424?

Patch doesn't apply for 9.5.2

Patch doesn't apply for 9.5.2

This patch only includes the missing operator parameter.

We noticed an issue that the condition operator is not transfered from the BlockVisibilityForm to the ConfigureVisibilityForm.
We could add an optional parameter to the layout_builder.add_visibility route with "and" as default.
I tried this and this seems to work.

Change to needs work for the language context issue.