- Issue created by @DiDebru
- last update
about 1 year ago 109 pass - Status changed to Needs review
about 1 year ago 12:32pm 5 December 2023 - 🇫🇮Finland tuutti
Looks like we don't have a test for shipping promotions. Using ->getAmount() probably won't work with partial discounts, like fixed 5€ off or -10%, but I'm not sure without actually testing this.
I don't have access to my commerce setup at the moment, so I'll get back to this later this week.
- Status changed to Needs work
about 1 year ago 6:41am 7 December 2023 - 🇫🇮Finland tuutti
Yeah, this doesn't seem to work with any other kind of discount than -100% off, but neither does the current implementation tho.
- 🇦🇹Austria agoradesign
I believe, it could be solved by skipping inside RequestBuilder line 162 not only positive adjustments, but also checking for if $adjustment->isIncluded() -> if it's already included, then we'll need to skip it
I hopefully can find a few minutes to test this theory
- 🇦🇹Austria agoradesign
This patch fixes the included promotion rules, but the other ones still fail.. I don't get it :DDD
but maybe it can help in some way...
- 🇦🇹Austria agoradesign
ok, we actually should have a look at commerce_paypal eg. -> https://git.drupalcode.org/project/commerce_paypal/-/blob/8.x-1.x/src/Ch...
I have to move on now, hopefully finding time on another day