Contrib.social

layout_builder_iframe_modal_update_8101() sets incorrect routes

Open on Drupal.org →
Created on 7 November 2023, over 1 year ago

Problem/Motivation

The layout_builder_iframe_modal_update_8101() update hook which was introduced in #3221612: Is there a way to only target blocks and not sections? → installs malformed configuration. It accidentally adds the "layout_builder" prefix twice to the routes:

layout_builder_iframe_routes:
  - layout_builder.layout_builder.configure_section
  - layout_builder.layout_builder.remove_section
  - layout_builder.layout_builder.remove_block
  - layout_builder.layout_builder.add_section
  - layout_builder.layout_builder.add_block
  - layout_builder.layout_builder.update_block
  - layout_builder.layout_builder.move_sections_form
  - layout_builder.layout_builder.move_block_form
  - layout_builder.layout_builder.translate_block
  - layout_builder.layout_builder.translate_inline_block

Looking through the history of that ticket: these double prefixes were added in an early iteration and fixed in commit 28abc41, but it was not realized that this was also affecting the update hook.

Steps to reproduce

  1. Install Layout Builder iFrame Modal 1.1.0
  2. Update to Layout Builder iFrame Modal 1.2.0

The malformed config will be installed in layout_builder_iframe_modal.settings.

Proposed resolution

Fix the broken update hook. Add a new post-update hook that updates already existing broken config.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024