- Issue created by @Oulalahakabu
- π«π·France Oulalahakabu
The concept of Drupal CS has been added. The sniffs listed in https://www.drupal.org/files/issues/2025-07-24/output.txt β have been addressed in this fork: https://git.drupalcode.org/issue/dsfr-3537568/-/compare/2.1.x...2.1.x?fr...
However, some points warrant further discussion:
- What is the benefit of abstracting
t()? In my opinion, there is none. Formclass: While the desire to minimize code is understandable, I see drawbacks:- It unnecessarily complicates the code.
- Methods with numerous parameters feel suboptimal.
- Naming conventions need review in certain areas. For example (non-exhaustive):
https://git.drupalcode.org/project/dsfr/-/blob/2.1.x/src/settings/Tools....getUrl()returning an array instead of aDrupal\Core\Urlobject could cause confusion.
https://git.drupalcode.org/project/dsfr/-/blob/2.1.x/src/settings/Form.p... method calledmargin()to get "margin options" causes confusion.
Naming conventions should also be taken into consideration in this issue.
- What is the benefit of abstracting
- Status changed to Needs work
about 1 month ago 8:12am 8 October 2025 - Merge request !7Impl drupal template for the readme file @see... β (Merged) created by Oulalahakabu
- Merge request !8Impl drupal template for the readme file @see... β (Merged) created by Oulalahakabu