Fix Drupal.Commenting.DocComment.SpacingBeforeTags coding standard

Time for some feedback here.

Not sure I follow the issue here? The spacing on the one file?

Yes, this is all about spacing and I think the sniff found legitimate problems.

Opened 📌 Fine tune Drupal.Commenting.DocComment.SpacingBeforeTags coding standard Active

Left a comment on the 1 thread but overall seems like a net gain to me.

Needs rebase, sorry. Will try to get this in sooner when it gets back to RTBC again.

Rebased with one conflict due to the change from http://www.w3.org to https://www.w3.org.

Since that was a trivial conflict and all the linting tests have passed, I am restoring the RTBC.

Spotted one false positive and two minor nits while I was reviewing this prior to commit.

@longwave, thanks.

Believe feedback from longwave on this has been addressed.

@longwave, thanks. I missed those two.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Done the rebase for the latest 11.x version. Now the auto test is green, moving to NR.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

All code changes look good to me.
I have run ddev exec -d /var/www/html "./vendor/bin/phpcbf core --standard=core/phpcs.xml.dist" on my local machine. With and without the MR and with the rule "Drupal.Commenting.DocComment.SpacingBeforeTags" included.
The results are as expected.
For me it is RTBC.

larowlan → closed merge request !8954

Committed to 11.x - thanks!

Automatically closed - issue fixed for 2 weeks with no activity.