- Status changed to Needs review
4 months ago 4:51am 18 August 2024 - đşđ¸United States smustgrave
Not sure I follow the issue here? The spacing on the one file?
- đłđżNew Zealand quietone
Yes, this is all about spacing and I think the sniff found legitimate problems.
- Status changed to RTBC
3 months ago 2:02pm 5 September 2024 - đşđ¸United States smustgrave
Opened đ Fine tune Drupal.Commenting.DocComment.SpacingBeforeTags coding standard Active
Left a comment on the 1 thread but overall seems like a net gain to me.
- đŹđ§United Kingdom longwave UK
Needs rebase, sorry. Will try to get this in sooner when it gets back to RTBC again.
- đłđżNew Zealand quietone
Rebased with one conflict due to the change from http://www.w3.org to https://www.w3.org.
Since that was a trivial conflict and all the linting tests have passed, I am restoring the RTBC.
- đŹđ§United Kingdom longwave UK
Spotted one false positive and two minor nits while I was reviewing this prior to commit.
- đşđ¸United States smustgrave
Believe feedback from longwave on this has been addressed.
- Status changed to Needs work
25 days ago 10:31am 8 November 2024 The Needs Review Queue Bot â tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide â to find step-by-step guides for working with issues.
- đŽđłIndia arunkumark Coimbatore
Done the rebase for the latest 11.x version. Now the auto test is green, moving to NR.
The Needs Review Queue Bot â tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide â to find step-by-step guides for working with issues.
- đłđąNetherlands daffie
All code changes look good to me.
I have runddev exec -d /var/www/html "./vendor/bin/phpcbf core --standard=core/phpcs.xml.dist"on my local machine. With and without the MR and with the rule "Drupal.Commenting.DocComment.SpacingBeforeTags" included.
The results are as expected.
For me it is RTBC.