Enable LineLength for core/modules excluding test

Let's get some review of these changes.

Changes read fine to me, rule would of captured missed ones I'm assuming.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased with a conflict in LayoutBuilderAccessCheck.php.

Good rebase

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased, and needs a review of the change for a conflict.

Seems conflict was around core/modules/system/system.post_update.php update seems fine

catch → closed merge request !11518

catch → reopened merge request !11518

It looks like new violations have been added since the last time this was rebased.

FILE: /home/catch/www/drupal/core/modules/menu_ui/src/Hook/MenuUiHooks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 118 | WARNING | Line exceeds 80 characters; contains 93 characters
     |         | (Drupal.Files.LineLength.TooLong)
--------------------------------------------------------------------------------


FILE: ...catch/www/drupal/core/modules/contextual/src/Hook/ContextualThemeHooks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 41 | WARNING | Line exceeds 80 characters; contains 83 characters
    |         | (Drupal.Files.LineLength.TooLong)
 44 | WARNING | Line exceeds 80 characters; contains 84 characters
    |         | (Drupal.Files.LineLength.TooLong)
--------------------------------------------------------------------------------


FILE: /home/catch/www/drupal/core/modules/block/src/Hook/BlockHooks.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  85 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
  90 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
 101 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
------------------------------------------------------------------

Rebase. And more changes in the last commit to review.

Reviewed the additional changes in commit https://git.drupalcode.org/project/drupal/-/merge_requests/11518/diffs?c... and they seem fine.

Another new one in:

core/modules/update/src/UpdateRoot.php

Rebased and made a change for core/modules/update/src/UpdateRoot.php

Try this again lol, additional changes seem fine. Restoring status

Let's ship this before it needs yet another reroll.

Committed f0f2901 and pushed to 11.x. Thanks!

longwave → closed merge request !11518