Only use colons in case statements

Deprecation of colon is commited to PHP 8.5

https://github.com/php/php-src/commit/5f8d648af6ef4e29a3c7f2b2029d08466c...

Updated IS

Code was fixed in 📌 Inconsistent switch case syntax Downport

but sniffer is not enabled https://github.com/PHPCSStandards/PHPCSExtra/commit/6f023adc8e28dbdcd21a...

sniffer in PSR2 https://github.com/squizlabs/PHP_CodeSniffer/commit/931842ab6f5d2809c3d4...

ready for review/commit

EDIT failed sniff https://git.drupalcode.org/issue/drupal-2901831/-/jobs/6176971

Seems straight enough. Not sure if the word should be a cspell ignore in the phpcs file but don’t feel too strong about that

cspell fix is required, see the job

Moreover PHP 8,5 beta1 CI image created and test run showing serious log pollution https://git.drupalcode.org/issue/drupal-3523596/-/jobs/6189639

Let's not add this to the dictionary - it is not a word.

We can added it to the phpcs.xml.dist file like so:

<?xml version="1.0" encoding="UTF-8"?>
<!-- cspell:ignore Openercase -->
<ruleset name="drupal_core">

Thank you, never know it could work like that)

this approach much cleaner!

Back to rtbc, this is indeed a better solution.

Can we move it to the top of the file... because this can become a list of all the non-words in the file. It's easier to maintain I think.

moved after meaningful descrtiption

For me it bleongs belong the xml - it's got nought to do with the running of the file... and having it there would be inline with having it after the namespace like we do with PHP.

The aim is to have it easy to spot and easy to ignore.

looks like all php-files are inserting it before namespace but a lot of others doing it after `use` so probably makes sense to formalize it)

Looks great now. I dunno about formalising things - like this is the first XML fill we've added this to I think.

Given PHP has deprecated this it is no longer an issue for our coding standards committee (they have no choice here anymore) so merging this to 11.x to stop any new cases getting back in to core.

We need to open an issue to backport 📌 Inconsistent switch case syntax Downport to 10.6.x / 10.5.x so that branch can get PHP 8.5 testing and compatibility.

Committed ef77219 and pushed to 11.x. Thanks!

andypost → closed merge request !12964

Filed follow-up for 10.x backport 📌 10.x backport - Inconsistent switch case syntax Active