- Issue created by @quietone
- Merge request !8389Convert code blocks in comments using array() syntax to @code/@endcode β (Open) created by quietone
- Status changed to Needs review
13 days ago 12:04pm 12 June 2024 - Status changed to RTBC
13 days ago 1:59pm 12 June 2024 - πΊπΈUnited States smustgrave
With the MRs still applied from π Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work and π Convert use of array() syntax in sentences Needs review ran the grep and got 4 instances
3 believe belong to π Convert use of array() syntax in sentences Needs review so moved that one back to NW
The last one
scripts/dump-database-d7.sh: $result = db_query('SELECT * FROM {'. $table .'}', array(), array('fetch' => PDO::FETCH_ASSOC));Believe doesn't need to be changed because it's a script?
Going to mark this one.
- Status changed to Needs work
8 days ago 5:56pm 17 June 2024 - πΊπΈUnited States xjm
So, while these are all totally correct changes, we're missing an equivalent PHPCS rule to the one from π Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work for these. We need a followup for that in the appropriate queue.
I'd be fine to treat the rule as either blocker or followup since the scope is really small, but we do need the rule.