- Issue created by @quietone
- Merge request !8389Convert code blocks in comments using array() syntax to @code/@endcode β (Open) created by quietone
- Status changed to Needs review
6 months ago 12:04pm 12 June 2024 - Status changed to RTBC
6 months ago 1:59pm 12 June 2024 - πΊπΈUnited States smustgrave
With the MRs still applied from π Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work and π Convert use of array() syntax in sentences Needs review ran the grep and got 4 instances
3 believe belong to π Convert use of array() syntax in sentences Needs review so moved that one back to NW
The last one
scripts/dump-database-d7.sh: $result = db_query('SELECT * FROM {'. $table .'}', array(), array('fetch' => PDO::FETCH_ASSOC));Believe doesn't need to be changed because it's a script?
Going to mark this one.
- Status changed to Needs work
6 months ago 5:56pm 17 June 2024 - πΊπΈUnited States xjm
So, while these are all totally correct changes, we're missing an equivalent PHPCS rule to the one from π Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work for these. We need a followup for that in the appropriate queue.
I'd be fine to treat the rule as either blocker or followup since the scope is really small, but we do need the rule.
- Status changed to Needs review
2 months ago 4:07am 26 September 2024 - π³πΏNew Zealand quietone
I prefer a followup up. I think it is unlikely that short array syntax will be added in new changes.
Follow up made, π Add rule to detect code blocks using long array syntax in comments Active
- πΊπΈUnited States smustgrave
Per the other one would agree with pushing some to a follow up as this is an incremental improvement.
Thanks @quietone for keeping up with all these.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
Rebase because Drupal.Commenting.VariableComment.VarOrder has been enabled. Conflicts in the following.
FILE: /builds/project/drupal/core/lib/Drupal/Core/Database/Query/Select.php
FILE: /builds/project/drupal/core/lib/Drupal/Core/Database/Log.php
FILE: /builds/project/drupal/core/lib/Drupal/Core/Database/Database.php