Fix code quality: Add accessCheck to entity queries and inject service

Created on 20 May 2024, about 1 month ago
Updated 2 June 2024, 24 days ago

Problem/Motivation

Major - Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

in src/Form/OpenIDConnectClientFormBase.php:133

Major - \Drupal calls should be avoided in classes, use dependency injection instead

in src/Plugin/OpenIDConnectClientCollection.php:61

Copied from MR !108

Proposed resolution

  1. Add a call to accessCheck() with the correct parameter.
  2. Inject the service, rather than calling \Drupal

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Needs work

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024