Coding standard & Dependency injection issue

Created on 11 September 2022, almost 3 years ago
Updated 3 June 2025, 29 days ago

Coding standards & Dependency injection issue

FILE: /web/modules/contrib/otp_login/js/intlTelInput.min.js
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/js/intl_phone.js
-----------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
24 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Form/BasicSettingsForm.php
-------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------
13 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [ ] Missing member variable doc comment
51 | ERROR | [x] list(...) is forbidden, use [...] instead.
56 | ERROR | [x] list(...) is forbidden, use [...] instead.
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Form/OtpLoginForm.php
----------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------------------------
15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
23 | ERROR | [ ] Class property $OTP should use lowerCamel naming without underscores
25 | ERROR | [ ] Missing member variable doc comment
26 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [ ] Missing member variable doc comment
166 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
172 | ERROR | [x] list(...) is forbidden, use [...] instead.
173 | ERROR | [x] list(...) is forbidden, use [...] instead.
195 | WARNING | [ ] Unused variable $request.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Form/UserPurgeForm.php
------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [ ] Parameter $entity_type_manager is not described in comment
59 | ERROR | [ ] Doc comment for parameter $entity_manager does not match actual variable name $time
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Otp.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 3 WARNINGS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
56 | ERROR | [ ] Missing member variable doc comment
57 | ERROR | [ ] Missing member variable doc comment
58 | ERROR | [ ] Missing member variable doc comment
73 | ERROR | [ ] Parameter $entity_type_manager is not described in comment
82 | ERROR | [ ] Doc comment for parameter $entity_manager does not match actual variable name $config_factory
132 | ERROR | [ ] The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
132 | ERROR | [ ] The array declaration extends to column 122 (the limit is 80). The array content should be split up over multiple lines
296 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
305 | ERROR | [x] list(...) is forbidden, use [...] instead.
306 | ERROR | [x] list(...) is forbidden, use [...] instead.
329 | WARNING | [ ] Unused variable $request.
354 | ERROR | [ ] The array declaration extends to column 139 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Plugin/rest/resource/OtpLogoutResource.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
98 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up over multiple lines
102 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Plugin/rest/resource/OtpSubmitResource.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
98 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/otp_login/src/Plugin/Block/OtPLoginLink.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
21 | ERROR | Class name doesn't match filename; expected "class OtPLoginLink"
----------------------------------------------------------------------------------------------------

Time: 496ms; Memory: 14MB

🐛 Bug report
Status

RTBC

Version

2.0

Component

Code

Created by

🇮🇳India jeetmail72 Noida

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024