- Issue created by @urvashi_vora
- Status changed to Needs work
over 2 years ago 6:53am 19 July 2023 - 🇵🇭Philippines paraderojether
Hi
I reviewed patch coding-standard-fixes.patch and still getting the error shown below:
FILE: ...t/modules/contrib/configurable_views_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 164 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- Time: 300ms; Memory: 10MBPlease check.
Thank you. - Status changed to Needs review
over 2 years ago 7:28am 19 July 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
I have resolved that error. Please review the MR.
- Status changed to RTBC
over 2 years ago 6:49am 20 July 2023 - 🇵🇭Philippines paraderojether
I reviewed MR!5, applied against Configurable Views Filter Block 1.0.x-dev, and confirmed it fixes the issues reported by phpcs.
I added screenshot for reference.
Thank you. - 🇪🇸Spain manuel.adan 🌌
manuel.adan → made their first commit to this issue’s fork.
-
manuel.adan →
committed 4df421d3 on 1.0.x authored by
urvashi_vora →
Issue #3372769 by urvashi_vora, manuel.adan: Fix the issues reported by...
-
manuel.adan →
committed 4df421d3 on 1.0.x authored by
urvashi_vora →
- 🇪🇸Spain manuel.adan 🌌
Reviewed & committed, automatic tests are now green. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.