Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 6 July 2023, 12 months ago
Updated 20 July 2023, 11 months ago

Problem/Motivation

FILE: ...iews_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
125 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
318 | ERROR | [ ] Type hint "array" missing for $element
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 90ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig configurable_views_filter_block/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    🇵🇭Philippines paraderojether

    Hi

    I reviewed patch coding-standard-fixes.patch and still getting the error shown below: 

    FILE: ...t/modules/contrib/configurable_views_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 164 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

Time: 300ms; Memory: 10MB

    Please check.
    Thank you.

  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇮🇳India urvashi_vora Madhya Pradesh, India

    I have resolved that error. Please review the MR.

  • @urvashi_vora opened merge request.
  • Comment 11 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to RTBC 11 months ago
  • Comment 11 months ago →
    🇵🇭Philippines paraderojether

    I reviewed MR!5, applied against Configurable Views Filter Block 1.0.x-dev, and confirmed it fixes the issues reported by phpcs.

    I added screenshot for reference.
    Thank you.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024