- Issue created by @quietone
- @quietone opened merge request.
- 🇺🇸United States smustgrave
Do we want to open a follow up for the one thread?
Rest seems fine
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand quietone
Another rebase, with a conflict that needs review.
- 🇬🇧United Kingdom catch
It's not good that phpcs is forcing us to ignore this rule when the documentation is there, but when there is another phpcs rule in place that breaks this rule. To me this feels worse than not having the rule enabled at all to be honest.
- 🇳🇿New Zealand quietone
Follow up made 📌 Fix unneeded Drupal.Commenting.FunctionComment.Missing Active
The MR is what it was when catch commented. I have commented, made an issue in Coder and a follow up for core, so I think it is OK to restore the RTBC.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.