Fix the issues reported by PHPCS

Created on 13 April 2023, over 1 year ago
Updated 27 April 2023, over 1 year ago

Problem/Motivation

FILE: ...web/modules/contrib/gin_toolbar_custom_menu/gin_toolbar_custom_menu.module
--------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
3 | ERROR | [ ] Missing short description in doc comment
27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
68 | ERROR | [ ] The array declaration extends to column 91 (the limit is 80).
| | The array content should be split up over multiple lines
76 | ERROR | [x] Expected 1 space after IF keyword; 0 found
79 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ontrib/gin_toolbar_custom_menu/src/Render/Element/GinToolbarCustomMenu.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------

FILE: .../contrib/gin_toolbar_custom_menu/src/Form/GinToolbarCustomMenuSettings.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
45 | WARNING | Menu::loadMultiple calls should be avoided in classes, use
| | dependency injection instead
65 | WARNING | Do not concatenate strings to translatable strings, they should
| | be part of the t() argument and you should use placeholders
84 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
89 | WARNING | Do not concatenate strings to translatable strings, they should
| | be part of the t() argument and you should use placeholders
93 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

FILE: ...odules/contrib/gin_toolbar_custom_menu/gin_toolbar_custom_menu.routing.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...es/contrib/gin_toolbar_custom_menu/gin_toolbar_custom_menu.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
2 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 543ms; Memory: 12MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig gin_toolbar_custom_menu/

Proposed resolution

Resolve all issues for Drupal and DrupalPractice coding standards.

Remaining tasks

Patch review and fix remaining issues

FILE: .../contrib/gin_toolbar_custom_menu/src/Form/GinToolbarCustomMenuSettings.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
45 | WARNING | Menu::loadMultiple calls should be avoided in classes, use
| | dependency injection instead
84 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
93 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

Time: 552ms; Memory: 12MB

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024