Missing parameter type

Created on 15 May 2020, about 4 years ago
Updated 9 August 2023, 11 months ago

Problem/Motivation

As a part of https://www.drupal.org/project/redirect/issues/2850121 πŸ› Fix coding standards Postponed we should fix the coding standard issues for:

Missing parameter type

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine andralex Lviv

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Assigning to myself as I'm triaging all RTBC issues.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks for the issue, patches, and review.

    Normally, all phpcs problems should be in one issue, see:

    πŸ› Fix coding standards Postponed

    But, given the extensive coding standard problems, then I'm okay with this one being separate since it has quite a few on its own.

    Applied the patch and ran:

    phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
    

    and didn't see any more Missing parameter type. See results.

    I need to review the code with fresh eyes but this one might be okay to merge.

Production build 0.69.0 2024