Fix LongLineDeclaration in KernelTests

Open on Drupal.org →

Created on 17 March 2025, about 2 months ago

Problem/Motivation

The sniff, Drupal.Array.Array.LongLineDeclaration is not enabled.

Steps to reproduce

Proposed resolution

Enable Drupal.Array.Array.LongLineDeclaration for KernelTests tests.

There are no strict standards for how to split a call to a function across multiple lines. The changes try to be the best fit for readability and the current style used in the file or method.

Remaining tasks

Review

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

other

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

!11510Fix LongLineDeclaration in KernelTests
Open
🇳🇿New Zealand quietone
updated about 9 hours ago

Comments & Activities

Issue created by @quietone
Merge request !11510KernelTests → (Open) created by quietone
Comment about 2 months ago →
🇳🇿New Zealand quietone
Linting passes, so NR.
Comment about 2 months ago →
🇺🇸United States smustgrave
Pretty straight forward
Comment about 1 month ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment about 1 month ago →
🇳🇿New Zealand quietone
There were no conflicts
Comment 26 days ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment 26 days ago →
🇳🇿New Zealand quietone
A rebase and an additional change.
Pipeline finished with Success
26 days ago
Total: 645s
#477068
Comment 26 days ago →
🇺🇸United States smustgrave
additional change seems fine.
Comment 9 days ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Pipeline finished with Success
8 days ago
Total: 498s
#490799
Comment 8 days ago →
🇳🇿New Zealand quietone
Rebase and wew fixes in the last commit to review
Comment 4 days ago →
🇺🇸United States smustgrave
Reviewed last commit https://git.drupalcode.org/project/drupal/-/merge_requests/11510/diffs?c... and seem fine
Comment 1 day ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Pipeline finished with Success
about 8 hours ago
Total: 2527s
#497657
Comment about 8 hours ago →
🇳🇿New Zealand quietone
Rebase and change in EntityDefinitionUpdateMultipleTypesTest.php

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024