[3.0.x] Paragraph Group

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. FILE: paragraph_group.libraries.yml

  main:
    version: VERSION

  settings:
    version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

2. FILE: paragraph_group.module

/**
 * @file
 * Contains paragraph_group.module.
 */

The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.

/**
 * Implements hook_form_FORM_ID_alter().
 *
 * @param array $form
 *   The form array, passed by reference.
 * @param \Drupal\Core\Form\FormStateInterface $form_state
 *   The form state object.
 * @param string $form_id
 *   The form ID.
 */
function paragraph_group_form_paragroup_config_form_alter(

/**
 * Implements hook_form_FORM_ID_alter().
 *
 * @param array $form
 *   The form array, passed by reference.
 * @param \Drupal\Core\Form\FormStateInterface $form_state
 *   The form state object.
 * @param string $form_id
 *   The form ID.
 */
function paragraph_group_form_system_themes_admin_form_alter(

The description for this hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).

3. FILE: src/Form/ParagroupConfigForm.php

  /**
   * Constructor.
   *
   * @param \Drupal\paragraph_group\Paragroup\ParagroupBatch $batch_obj
   *   The batch processing service.
   * @param \Drupal\paragraph_group\Paragroup\ParagroupFormData $form_data
   *   The form data service.
   */
  public function __construct(

FILE: src/Paragroup/ParagroupBatch.php

  /**
   * Constructor.
   *
   * @param \Drupal\Core\StringTranslation\TranslationInterface $string_translation
   *   The string translation service.
   * @param \Drupal\paragraph_group\Paragroup\ParagroupFormData $form_data
   *   The form data service.
   */
  public function __construct(

FILE: src/Paragroup/ParagroupFormData.php

  /**
   * Constructor.
   *
   * @param \Drupal\Core\StringTranslation\TranslationInterface $string_translation
   *   The string translation service.
   */
  public function __construct(TranslationInterface $string_translation) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.

Thanks for your replies everyone. The fixes mentioned by @vishal.kadam should be fine, but I'm also setting up Gitlab CI as well as advised by @avpaderno. So I'll let you know when I've completed all the resulting fixes asap.

Hi all,

I have now:

1. Implemented Gitlab CI for my module, and duplicated it's PHPCS configuration in my local development environment.
2. Fixed all issues noted by PHPCS. Commits at https://git.drupalcode.org/project/paragraph_group are now passing the PHPCS test in the Gitlab CI build pipeline.
3. Also fixed the issues raised by Vishal Kadam above.

So please let me know any further issues, and I'll do my best to address them asap. Appreciate your help.