Thank you very much for the patch. It has been applied.
Thank you very much for the patch. It has been applied.
@stevenx From the MR I sent you can get the patch with the same solution you sent later.
Hello @lazzyvn,
I have not received credit for helping with this task.
Could you please review the credit attribution @lazzyvn?
With paragraphs 8.x-1.17 version works ok.
This path if for version 8.x-1.18
I generate a new patch to solve this issue.
Can anyone help to merge this request? thank you very much.
I have generated a new RM on the 2.x branch.
https://git.drupalcode.org/project/gin_login/-/merge_requests/33
I have added a file as documentation of the new hook in the MR gin_login.api.php
Hello,
I have tested the MR 6 patch and it works perfectly with the 2.x branch.
I think you could merge it perfectly without affecting the expected module performance.
Also I think it is very good approach and solution.
Could you please check this issue and try to merge?
I was having the same problem and your patch resolved.
@Eli-T
It was a mistake, because there was a custom code in the project that caused the problem.
Now I'm ok with the patch you sent.
This is the error I get once I have removed the dependency with state
───────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
│ File: 3376399.patch
───────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
1 │ diff --git a/src/Asset/JsCollectionOptimizerLazy.php b/src/Asset/JsCollectionOptimizerLazy.php
2 │ index 361bad0..33ed3c4 100644
3 │ --- a/src/Asset/JsCollectionOptimizerLazy.php
4 │ +++ b/src/Asset/JsCollectionOptimizerLazy.php
5 │ @@ -16,7 +16,6 @@ class JsCollectionOptimizerLazy extends DrupalJsCollectionOptimizerLazy {
6 │ * {@inheritdoc}
7 │ */
8 │ public function deleteAll() {
9 │ - $this->state->delete('system.js_cache_files');
10 │ try {
11 │ $this->fileSystem->deleteRecursive($this->getSchemeForExtension('js') . '://js');
12 │ } catch (FileException $fileException) {
TypeError: Drupal\Core\Asset\JsCollectionOptimizer::__construct(): Argument #3 ($dumper) must be of type Drupal\Core\Asset\AssetDumperI
nterface, Drupal\Core\Theme\ThemeManager given in Drupal\Core\Asset\JsCollectionOptimizer->__construct() (line 69 of /var/www/cms/docroot/core/lib/Drupal/Core/Asset/JsCollectionO
ptimizer.php) #0 [internal function]: Drupal\Core\Asset\JsCollectionOptimizer->__construct(Object(Drupal\Core\Asset\JsCollectionGrouper), Object(Drupal\Core\Asset\JsOptimizer), O
bject(Drupal\Core\Theme\ThemeManager), Object(Drupal\Core\Asset\LibraryDependencyResolver), Object(Symfony\Component\HttpFoundation\RequestStack), Object(Drupal\flysystem_s3\File
\FlysystemS3FileSystem), Object(Drupal\Core\Config\ConfigFactory), Object(Drupal\Core\File\FileUrlGenerator), Object(Drupal\Component\Datetime\Time), Object(Drupal\language\Confi
gurableLanguageManager))
I have the same problem as @Robin.Houtevelts in comment #30.
Sorry.
I had some old patches in composer.json and that made my mistake.
I apologize
I have installed via composer
- drupal core 10.2.1
- flysystem 2.2.0-alpha1
I ran "drush deploy" command on the terminal and got the error.
Thank you for your contribution.
There is already a new version with drupal 10 support.
These fields are translatable @dimKarp
Thanks @alexortega_98
Great work
Thanks! xD