- Issue created by @Antonín Slejška
- Merge request !89Use the interface SitemapGetterInterface instead of the class Generator. → (Open) created by Antonín Slejška
- last update
3 months ago 32 pass - Status changed to Needs review
3 months ago 2:20pm 21 March 2024 - Status changed to RTBC
3 months ago 2:23pm 21 March 2024 - Status changed to Needs work
3 months ago 7:23am 22 March 2024 - 🇷🇺Russia WalkingDexter
First of all, PHPStan errors need to be fixed https://git.drupalcode.org/issue/simple_sitemap-3432628/-/jobs/1121610.
- last update
3 months ago 32 pass - last update
3 months ago 32 pass - Status changed to Needs review
3 months ago 2:53pm 22 March 2024 - Status changed to Needs work
3 months ago 3:32pm 22 March 2024 - 🇩🇪Germany gbyte Berlin
The generator should have its own interface 'GeneratorInterface' and additionaly implement the existing 'SitemapGetterInterface'. 'GeneratorInterface' should not extend 'SitemapGetterInterface'.
- last update
3 months ago 32 pass - Status changed to Needs review
3 months ago 4:04pm 22 March 2024 - 🇩🇪Germany Antonín Slejška Hannover
Hi @gbyte, I have implemented it, as you suggested. It works by me locally, but it causes the following issues:
https://git.drupalcode.org/issue/simple_sitemap-3432628/-/jobs/1132670 - Status changed to Needs work
3 months ago 4:06pm 22 March 2024 - last update
3 months ago 32 pass - Status changed to Needs review
3 months ago 4:21pm 22 March 2024 - 🇩🇪Germany Antonín Slejška Hannover
I have added the methods setSitemaps and getSitemaps to the GeneratorInterface. It works: https://git.drupalcode.org/issue/simple_sitemap-3432628/-/pipelines/126371
But I'm not sure, if it is the best solution. Why not to use 'extend'?