Use SitemapGetterInterface instead of Generator in services

This looks reasonable to me.

First of all, PHPStan errors need to be fixed https://git.drupalcode.org/issue/simple_sitemap-3432628/-/jobs/1121610.

The generator should have its own interface 'GeneratorInterface' and additionaly implement the existing 'SitemapGetterInterface'. 'GeneratorInterface' should not extend 'SitemapGetterInterface'.

Hi @gbyte, I have implemented it, as you suggested. It works by me locally, but it causes the following issues:
https://git.drupalcode.org/issue/simple_sitemap-3432628/-/jobs/1132670

I have added the methods setSitemaps and getSitemaps to the GeneratorInterface. It works: https://git.drupalcode.org/issue/simple_sitemap-3432628/-/pipelines/126371
But I'm not sure, if it is the best solution. Why not to use 'extend'?

The patches aren't applicable to version 4.2.1, so here's a rewritten patch that will apply

Patch from #11 doesn't apply in 4.2.2, therefore here another rewrite

walkingdexter → closed merge request !115

walkingdexter → closed merge request !116

mhh → changed the visibility of the branch 3432628-generator-interface-4.2.2 to hidden.

I've created a new MR with all the changes that work with the current 4.x branch (MR !126). I've also rewritten it as a patch to work with 4.2.2.

This changes currently do not work. If I do open the config page at /admin/config/search/simplesitemap, then I do get this error:

PHP message: Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: "Cannot autowire service "Drupal\simple_sitemap\Manager\Generator": argument "$generator" of method "Drupal\simple_sitemap\Form\StatusForm::_construct()", you should configure its value explicitly.

Tested with version 4.2.2 of simple sitemap.

The circumstances are different. The MR is against the 4.x-dev branch. There it works. Against version 4.2.2 it just does not apply. Because there are various changes in the 4.x-dev branch which differ from the 4.2.2 release.

I do recommend to merge the changes in 4.x-dev and then create an new patch release (e.g. 4.2.3).

I can confirm that the patch from #20 does also work, if applied against version 4.2.2.

@gbyte The changes look good to me, please review.