Block Plugins don't store their context mappings on submit

vidorado → changed the visibility of the branch 11.x to hidden.

vidorado → changed the visibility of the branch 3251378-8.9.x to hidden.

vidorado → changed the visibility of the branch 3251378-block-plugins-dont to hidden.

Added a Kernel test to test the new behavior.

smustgrave → closed merge request !1447

smustgrave → closed merge request !1446

Left comments on MR for consistency

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

@smustgrave, I've applied your two suggestions and left a reply to your third MR comment of what I think @rlmumford pretended to do.

Thanks!

Leaving the 1 thread open but rest of the feedback appears to be addressed

I kind of wondered if we want functional test coverage for this to show what actually breaks (which I am not clear about to be honest), but the kernel test is pretty clear.

Committed/pushed to 11.x, thanks!

catch → closed merge request !10924

Automatically closed - issue fixed for 2 weeks with no activity.

This should have a change record because now any overrides of BlockBase::submitConfigurationForm() require the void typehint.

Yeah just hit #27 when hunting down phpunit failures on 11.2

PHP Fatal error: Declaration of Drupal\entity_hierarchy_microsite\Plugin\MicrositePluginTrait::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\Core\Block\BlockBase::submitConfigurationForm(array &$form, Drupal\Core\Form\FormStateInterface $form_state): void in /data/app/modules/contrib/entity_hierarchy/modules/entity_hierarchy_microsite/src/Plugin/MicrositePluginTrait.php on line 90

Example in contrib: https://www.drupal.org/project/spa/issues/3526733#comment-16203161 ✨ Allow to set an aria-label on the iframe element Active (comment #8)

I'm wondering if we should specify the return type when there is no return type on the interface in this case PluginFormInterface yet.

@harlor see 🐛 Remove return type from BlockBase::submitConfigurationForm Active , we are reverting the return type.