- Merge request !1446Make sure context_mapping information is stored in BlockBase::submitConfigurationForm → (Closed) created by rlmumford
- Merge request !1447Issue #3251378 by rlmumford: Make sure context mapping gets stored in BlockPluginTrait. → (Closed) created by rlmumford
- First commit to issue fork.
- 🇪🇸Spain vidorado Logroño (La Rioja)
vidorado → changed the visibility of the branch 11.x to hidden.
- 🇪🇸Spain vidorado Logroño (La Rioja)
vidorado → changed the visibility of the branch 3251378-8.9.x to hidden.
- 🇪🇸Spain vidorado Logroño (La Rioja)
vidorado → changed the visibility of the branch 3251378-block-plugins-dont to hidden.
- Merge request !10924Issue #3251378: Block Plugins don't store their context mappings on submit → (Closed) created by vidorado
- 🇪🇸Spain vidorado Logroño (La Rioja)
Added a Kernel test to test the new behavior.
- 🇺🇸United States smustgrave
Left comments on MR for consistency
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- 🇪🇸Spain vidorado Logroño (La Rioja)
@smustgrave, I've applied your two suggestions and left a reply to your third MR comment of what I think @rlmumford pretended to do.
Thanks!
- 🇺🇸United States smustgrave
Leaving the 1 thread open but rest of the feedback appears to be addressed
- Issue was unassigned.
- Status changed to RTBC
24 days ago 2:30am 15 April 2025 - 🇬🇧United Kingdom catch
I kind of wondered if we want functional test coverage for this to show what actually breaks (which I am not clear about to be honest), but the kernel test is pretty clear.
Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.