- Issue created by @robphillips
- Merge request !650Fixed TypeError when toolbar item has no tooltip element β (Open) created by robphillips
I could not reproduce the error, but I also don't see any error or unexpected behavior with the patch applied.
- πΊπΈUnited States robphillips
You need to add a logo. The default logo uses different markup that does not cause a TypeError. Another potential solution is to wrap the
<img>
tag with a<span>
tag. Addressing the issue in JavaScript ensures this problem won't occur with other toolbar items that may not follow the exact Gin structure.See
navigation--gin.html.twig
:{% if icon_path %} <a class="toolbar-link" href="{{ path('<front>') }}"> <img alt="{{ 'Home'|t }}" src="{{ file_url(icon_path) }}" loading="eager" /> </a> {% else %} <a href="{{ path('<front>') }}" class="toolbar-link toolbar-link--has-icon toolbar-link--gin-home"> <span>{{ 'Home'|t }}</span> </a> {% endif %}
- π¬π§United Kingdom schillerm
Hi hello,
I also unable to reproduce this error. Tried on D11 site with gin theme 5.0.x and navigation module 11.2.3 enabled. Was able to set a custom logo using navigation settings here .. /admin/config/user-interface/navigation/settings.
Cleared cache collapsed the left side admin toolbar and tried to see the error in the console, nothing showing up (Tried Brave and Thorium browsers).Changed Gin branch to 3539156-uncaught-typeerror-when, retested same result.