Claro primary tabs collapsed menu hamburger icon has insufficient contrast with forced-colors dark background

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .

Hi @kentr, i think the proposed resolution may not work in this case as that hamberger menu is a svg image so we can add fill: linketext to its < path/> tag when forced color mode is active to fix this issue. Do you agree with it?

@sandip poddar:

It should work... That said, my proposal was biased because I had been working on an issue where a media query inside the svg didn't work.

Your proposal is simpler and less invasive, and I've also learned from @Curtis Wilcox in Slack that:

• in this case the role is a button and the color should be ButtonText
• because this is an inline SVG, using currentColor will allow the colors to inherit from the parent button which will have the correct color in forced-colors mode

I updated the IS proposed resolution based on the suggestions from you and @Curtis Wilcox.

I'm also only finding this one instance in Claro of an inline SVG. Maybe it would be better to convert it to a background image for consistency.

Ultimately, it's up to the maintainers.

Hi @kentr,
Thank you for the information. I'll proceed with raising a MR as outlined in the Proposed resolution.

I'm also only finding this one instance in Claro of an inline SVG. Maybe it would be better to convert it to a background image for consistency.

That sounds reasonable to me as well. If any maintainer agrees with this suggestion, I'll be happy to revert the changes. For now, I'll go ahead and raise the MR as mentioned in point #4.

Attaching Screenshot for review.

Seems there is some feedback on the MR.

Updating the IS to include other browsers.

I am working on the feedback.

Please review the changes.

Passes testing on Mac in Edge, Firefox, Chrome.

Does protocol dictate also testing on other platforms with system high-contrast modes (such as WHCM)?

Gitlab won't let me resolve this MR comment, but it is resolved.

Hi @kentr, I have marked the thread as resolved based on your confirmation.

Believe feedback to addressed for this one.

small feedback, unnecessary nesting. You can RTBC once it's fixed

I am looking into it.

I have made the suggested changes and moving this issue to RTBC.

nod_ → closed merge request !11552

Committed 9031a4e and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.