- Issue created by @rkoller
- 🇨🇦Canada mgifford Ottawa, Ontario
In this example, the "Extend" link is orange on a light orange background. This is lower contrast than the other links, making it harder to read for many people. It should be the opposite.
- 🇩🇪Germany rkoller Nürnberg, Germany
i agree probably it might be not only about the color contrast but also about the font size, a detail we've touched before in yesterdays discussion. and i've updated the issue summary and added a pointer what the navigation block title is in the screenshot.
This issue of changing the color to meet Accessibility standard should be done on the Drupal Core since the style for the Administration title is applied from within the navigation module inside core (/web/core/modules/navigation/css/components/toolbar-block.css > .toolbar-block__title).
I've created another task for the Drupal Core here: https://www.drupal.org/project/drupal/issues/3506743 🐛 Increase the color contrast of the navigation block title Active- 🇩🇪Germany rkoller Nürnberg, Germany
for core and the navigation component there is already 🐛 Navigation block titles have a too low color contrast Active so 🐛 Increase the color contrast of the navigation block title Active is a duplicate of that. but i've opened the issue in here because you have a dark mode for gin that does not exist for core. and the shade of grey that is used for the navigation block title in gin is the same in light and dark mode. it is right to fix the color contrast for the navigation block title in core as well. but still the darker grey that will be picked as the solution for 🐛 Navigation block titles have a too low color contrast Active might then not work with the dark background in gin (and being mindful about gin would be out of scope for 🐛 Navigation block titles have a too low color contrast Active ). it might work but still out of scope and why i think it is reasonable having a dedicated issue.
- 🇩🇪Germany rkoller Nürnberg, Germany
and your proposed solution on the MR you've created with #222330 for the navigation block title color would have a color contrast of 1.1:1 against the background (rgb(42,42,45)) of the navigation sidebar in gin.
when my current proposed change on https://www.drupal.org/project/drupal/issues/3506743 🐛 Increase the color contrast of the navigation block title Active will be live, it should fix this issue as well since increasing the color from 600 to 800 also affects changes when in dark mode since the color gets inverted for dark mode as you can see in the screenshot, the color changes to rgb(210, 211, 211) or #d2d3d3 which does fit the standard with 9.5:1
- 🇩🇪Germany rkoller Nürnberg, Germany
?
if gin is using the exact same shade of grey as claro then grey 800 would be--admin-toolbar-color-gray-800: var(--drupal-admin-color-gray-800, #4f5661);
and that is color contrast of 1.9:1 against rgb(42,42,45) ... while the issue you have linked went to--admin-toolbar-color-gray-700: var(--drupal-admin-color-gray-700, #6d7583);
which is 3.1:1. #d2d3d3 is just --gin-color-text which is identical to the menu items. but as @ckrina pointed out on the other issue the block title should be an unobstrusive label to a nav block and should not be using the identcial coloring.