Toolbar buttons should respond to spacebar key

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Tagging for https://www.w3.org/WAI/WCAG21/Understanding/keyboard.html

Priority to Major because #21 tagged this with SC 2.1.1 and that SC is Level A.

I'm looking at the MR.

My last comment should have referenced #29. I edited my comment to correct.

Also adding STR to help with testing / reviewing.

kentr → changed the visibility of the branch 3085811-toolbar-buttons-should to hidden.

Opened a new MR against 11.x, so I'm hiding the original MR (!653).

I was able to make this work without scrolling by using only the keydown event, tested manually in Firefox and Brave (Chromium) on Mac.

Noting that neither the original MR nor this new one work for me in Safari v18.5.

I also discovered that the "Announcements" toolbar item will respond to the space key by the simple addition of the trigger CSS class. That should be a separate issue, b/c it needs tests and probably should also have role="button".

Removed Global2020 tag because it appears to be outdated.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Made attempt to fix the patch apply error in #36. The current MR diff applies cleanly to 11.x for me.

There was one pipeline error that appeared to be related to the recent infrastructure problems and passed when re-run.

Just added tests involving the ENTER key, as specified by the proposed resolution.

NW until pipeline passes.

Back to needs review.

Also discovered that SPACE and ENTER keys do work in Safari when tab navigation is enabled the settings.

I am reviewing this

I have reviewed the merge request raised by @kentr, and it looks good to me. I’ve attached the before and after videos for reference. Additionally, I’ve added a log on click to verify that both the Space and Enter keys function as expected.

What else is needed to move this to RTBC?

I misunderstood the reason for using keyup with the space key.

I'll change it back to using two events and clarify that in the IS.