- πͺπΈSpain unstatu
Rerolled #22 aganist 1.18.
Changed the status to "Needs review"
- Status changed to Needs work
almost 2 years ago 1:59pm 9 February 2023 - πͺπΈSpain unstatu
Just read the points made by @micropat in #20. Not sure if this work has been done already on the dev branch. Are them still applicable?
Moving back to Needs work.
- πΊπΈUnited States micropat
@unstatu Nothing in the dev branch yet! A patch per #20 is very welcome for
8.x-1.x
&2.0.x
and would be a feature highlight in the next release. - π¬π§United Kingdom maseyuk
@ddiestra
It looks like the mentioned library in the patch "addtoany/addtoany" doesnt exist in 2.0
- Status changed to Postponed: needs info
over 1 year ago 1:29am 24 May 2023 - π¦πΊAustralia VladimirAus Brisbane, Australia
Checking if committed β¨ Cache external addtoany JS library and update the local cache with cron Needs review solved the issue?
- Status changed to Needs work
over 1 year ago 7:47am 25 May 2023 - Assigned to amoljadhav3435
Added a patch to load the AddtoAny library only on pages where the social share buttons are used.
- Issue was unassigned.
- πΊπΈUnited States micropat
Patch requirements on the
dev
branch so this feature can make a stable release:- Add a new
limit_loading
boolean config option (defaultfalse
per #17). - Add the
limit_loading
checkbox option in AddToAny config > Additional Options:
[ ] Only load AddToAny assets on pages that actively use this module. When enabled, dynamic AddToAny features and custom code may not work on all pages.
- In
addtoany_page_attachments()
, conditionally attach theaddtoany
library based on thelimit_loading
option. - Attach the
addtoany
library to all AddToAny render arrays.
- Add a new
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
Why not work on the MR created on comment #7 https://www.drupal.org/project/addtoany/issues/3056377#comment-13964345 β¨ Attach library to AddToAny render arrays, and add option to only load AddToAny assets upon module use Needs work instead of reroll constantly over the same changes?
- πͺπΈSpain eduardo morales alberti Spain, πͺπΊ
After reading comment #34 we understand that the solution is to attach the library add to any to the addtoany-standard template, and also add a configuration to load always the addtoany library to avoid errors on Ajax petitions on the preprocess page.
- π¬π§United Kingdom Ashley George
The patches for this stopped working for us after a recent module update. Inspecting the most recent patch version (under issue fork - plain diff), I can see that most of the changes are now in the module.
- π―π΄Jordan oways23
This is the same patch in comment #33, to make it work with the last update for the module.