- 🇺🇸United States chrissnyder Maryland
Patch #11 ✨ Cache external addtoany JS library and update the local cache with cron Needs review worked for me.
-
VladimirAus →
committed 3281e4aa on 2.0.x authored by
majid.ali →
Issue #3273208 by majid.ali, RockHard76, xamount, jukka792, VladimirAus...
-
VladimirAus →
committed 3281e4aa on 2.0.x authored by
majid.ali →
-
VladimirAus →
committed 305ee4ac on 8.x-1.x authored by
majid.ali →
Issue #3273208 by majid.ali, RockHard76, xamount, jukka792, VladimirAus...
-
VladimirAus →
committed 305ee4ac on 8.x-1.x authored by
majid.ali →
- Status changed to Fixed
over 1 year ago 10:52pm 23 May 2023 - Status changed to Needs work
over 1 year ago 9:13am 25 May 2023 - 🇺🇸United States micropat
Thanks @rockhard76 and @majidali for the patches.
#11 is getting close — great work. It had some issues in dev such as initially missing files so we had to revert, but happy to try another patch rolled for
2.0.x-dev
.Patches welcomed to make this feature robust and release-ready.
- 🇩🇪Germany majid.ali
I have update the #11 ✨ Cache external addtoany JS library and update the local cache with cron Needs review patch.
- Added a update hook to download scripts for existing projects using this module.
- Added install hook to to do the same for new installs.
- Added schema constraints.
- Found an issue that Drupal cleanup job deletes everything in
public://js
directory after 30 days\Drupal\Core\Asset\JsCollectionOptimizer::deleteAll()
. Therefore we have to move scripts frompublic://js/addtoany/menu/
topublic://addtoany/menu/
- Status changed to Needs review
over 1 year ago 5:06pm 23 June 2023 - 🇷🇴Romania abautu
On the patch from #19, I fixed two more issues:
- the library name is addtoany.front (instead of addtoany)
- the path to the static page file was missing a / before the page.js (i.e. addtoany/menu/cached_id/page.js)I tested this with 1.20 and 2.0 and works well.
- 🇷🇴Romania abautu
One of the servers that I deployed this patch on is using a web proxy to access internet. Drupal is configured properly (ie. http_proxy_config settings), but the patch from #21 failes to retrieve the files because it uses file_get_contents for HTTP requests. in this patch, I replaced file_get_contents with Drupal::httpClient()->get(...)->getBody()->getContents(), which does the same thing, but uses HTTP proxies as configured in Drupal.